dbg: envoy: Introduce possibility to change Envoy log level #35509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Envoy Admin Client that is used in the cilium-dbg closes the underlying connection by keeping a reference to it. This isn't necessary, as the HTTP client provides the method `CloseIdleConnections`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, the log level of the Envoy instance can only be configured (Helm) or adjusted during runtime (Rest API) globally. Envoy itself provides the possibility to configure the log levels per logger / Envoy component via its Admin interface (https://www.envoyproxy.io/docs/envoy/latest/operations/admin). This is helpful to reduce the amount of logs while investigating issues. Therefore, this commit introduces new commands to the cilium-dbg binary to list and change the log levels. * `cilium-dbg envoy admin logging list` * `cilium-dbg envoy admin logging set global <level>` * `cilium-dbg envoy admin logging set loggers <name>=<level>` Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
d6de661 to
d5b5f06
Compare
asauber
reviewed
Oct 23, 2024
asauber
approved these changes
Oct 23, 2024
sayboras
approved these changes
Oct 23, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the log level of the Envoy instance can only be configured (Helm) or adjusted during runtime (Rest API) globally.
Envoy itself provides the possibility to configure the log levels per logger / Envoy component via its Admin interface (https://www.envoyproxy.io/docs/envoy/latest/operations/admin).
This is helpful to reduce the amount of logs while investigating issues.
Therefore, this commit introduces new commands to the cilium-dbg binary to list and change the log levels.
cilium-dbg envoy admin logging listcilium-dbg envoy admin logging set global <level>cilium-dbg envoy admin logging set loggers <name>=<level>