Skip to content

Add neighbor asn label to metric #35503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add neighbor asn label to metric #35503

merged 2 commits into from
Nov 5, 2024

Conversation

mikejoh
Copy link
Contributor

@mikejoh mikejoh commented Oct 23, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #35502

bgp: Add `neighbor_asn` label to BGP metrics

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 23, 2024
@maintainer-s-little-helper
Copy link

Commit 2f5f531 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 4, 2024
@maintainer-s-little-helper
Copy link

Commit 2f5f531 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@mikejoh mikejoh marked this pull request as ready for review November 4, 2024 13:21
@mikejoh mikejoh requested review from a team as code owners November 4, 2024 13:21
@mikejoh
Copy link
Contributor Author

mikejoh commented Nov 4, 2024 •
edited
Loading

For consistency i've updated the PR and added the suggested neighbor_asn label to all BGP control-plane metrics in a seperate commit:

  • session_state
  • received_routes
  • advertised_routes

qmonnet
qmonnet requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Can you sign off your commit, please?

@qmonnet qmonnet added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/bgp Impacts the Border Gateway Protocol feature. labels Nov 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Nov 4, 2024
@mikejoh
Copy link
Contributor Author

mikejoh commented Nov 4, 2024

Thanks for this. Can you sign off your commit, please?

I had one commit that weren't signed, i amended and pushed again. AFAICT all commits are signed at the moment!

qmonnet
qmonnet reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could I also ask you to please squash some of your commits? The docs should build fine for each commit, which means that commit 4 should be squashed into commit 3. Ideally, we also want the doc update to happen at the same time as the code change, so commit 2 could be squashed into commit 1.

qmonnet
qmonnet approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@qmonnet
Copy link
Member

qmonnet commented Nov 4, 2024

/test

harsimran-pabla
harsimran-pabla approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@harsimran-pabla harsimran-pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mikejoh @julianwiedmann
metric: Add neighbor ASN label to BGP session state metric
23f7431 
Expand the BGP `session_state` metric with a label tracking the neighbor
ASN. By adding this label we allow for more granular monitoring and
analysis of BGP peers.

Signed-off-by: Mikael Johansson <mik.json@gmail.com>
@mikejoh @julianwiedmann
Add neighbor ASN label to total advertised and received route metrics
c2f363a 
Signed-off-by: Mikael Johansson <mik.json@gmail.com>
@julianwiedmann
Copy link
Member

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 5, 2024
Merged via the queue into cilium:main with commit ca74109 Nov 5, 2024
64 checks passed
@mikejoh mikejoh deleted the add-neighbor-asn-label-to-metric branch November 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

@doniacld doniacld Awaiting requested review from doniacld doniacld is a code owner automatically assigned from cilium/sig-policy

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add neighbor ASN label to BGP metric(s)
4 participants
@mikejoh @qmonnet @julianwiedmann @harsimran-pabla