operator: bind necessary policy flags #35599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
There was a bug where the operator was reporting policies containing ICMP fields as invalid, even though they were accepted by the daemon. It turns out that because option.Config.EnableICMPRules is populated by `vp.GetBool()`, it's not enough just to initialize it to the default value. We must bind that command-line argument as well. Fixes: cilium#35214 Signed-off-by: Casey Callendrello <cdc@isovalent.com>
f654f90 to
29ab2e0
Compare
pippolo84
approved these changes
Oct 29, 2024
|
/test |
nathanjsweet
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where the operator was reporting policies containing ICMP fields as invalid, even though they were accepted by the daemon. It turns out that because option.Config.EnableICMPRules is populated by
vp.GetBool(), it's not enough just to initialize it to the default value. We must bind that command-line argument as well.Fixes: #35214