CiliumEnvoyConfig handling for experimental control-plane #35598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01f253b to
0727129
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0727129 to
c50b945
Compare
c50b945 to
05320ac
Compare
05320ac to
ad1751b
Compare
|
What does "experimental" mean :-)? Is this expected to merge? Be used? Or should this be a draft PR? |
It is meant to be merged. Experimental as in it's meant to eventually replace the existing implementation and we're slowly building it up towards it. And yes hopefully people try this out in v1.17 ( |
ad1751b to
cde6d22
Compare
jrajahalme
approved these changes
Nov 5, 2024
ovidiutirla
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM for my code owners
We could potentially drop the hive bump after #35707 is merged.
squeed
reviewed
Nov 5, 2024
squeed
reviewed
Nov 5, 2024
squeed
reviewed
Nov 5, 2024
julianwiedmann
approved these changes
Nov 8, 2024
|
We should now be able to drop the hive bump commit 🚀 |
To allow filling in data from other tables during reflection, pass the current transaction to the transform functions. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Add ServicePort to Frontend to allow proxy redirection to match against NodePort frontends based on the service port (ClusterIP port). Add ports to the ProxyRedirect in Service to allow applying the redirect to only frontends matching the port. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Implement CiliumEnvoyConfig handling and backend syncing for the experimental LB control-plane. Signed-off-by: Jussi Maki <jussi@isovalent.com>
cde6d22 to
e27b9b8
Compare
|
/test |
squeed
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the CiliumEnvoyConfig handling against the experimental load-balancing control-plane (pkg/loadbalancer/experimental).
The
exp_cec.godefines theTable[CEC]containing the envoy configs. The CEC object defines the full desired envoy Resources, including backends. Changes to the object are reconciled against the XDS server.The main moving parts around
Table[CEC]are:Table[CEC]and sets the service L7 redirects accordingly.The implementation is tested with hive/script and builds on top of the test commands provided by the load-balancer control-plane:
testdata/namespaced.txtar: Tests CiliumEnvoyConfig and validates calls towards Envoy and the LB BPF map contentstestdata/clusterwide.txtar: Similar to namespaced.txtar but testing CiliumClusterwideEnvoyConfigtestdata/anyport.txtar: Tests CiliumEnvoyConfig without port filteringtestdata/labels.txtar: Tests selection of CiliumEnvoyConfigs based on node labels