bgpv2: Introduce a condition to indicate nodeSelector conflicts #35593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
189211d to
e54900f
Compare
|
/test |
harsimran-pabla
approved these changes
Oct 28, 2024
The current owner reference check checks the owner just by the name. This may matches to the owner of different kind of resource with the same name. Practically, it shouldn't happen, but for the sake of correctness, fix it. Also, unexport the IsOwner function since it is only used within the package. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Introduce a new status condition ConflictingClusterConfig to the CiliumBGPClusterConfig which indicates that the ClusterConfig is selecting the node that is already selected by other ClusterConfig. We reused an existing conflict detection mechanism in the Cilium Operator which checks the existing NodeConfig's owner reference when it tries to create the new NodeConfig. If there's another ClusterConfig owning the same node, it is observed as a conflict. Because of this detection mechanism, the condition in the single ClusterConfig doesn't have the global view of the conflict relationship. To get the complete view, users need to gather the observed conflicts from multiple ClusterConfigs. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
e54900f to
c08cecf
Compare
|
Rebased to resolve conflict |
|
/test |
|
Cilium IPsec upgrade: GitHub timeout |
|
Closing since the content of this PR is mistakenly merged in #35601 which was suppose to be a doc-only PR. #35601 was built on targeted the this branch, but I switched the base branch in the middle. I meant to merge the docs change first, but I forgot to remove the commits came from the old base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node in the cluster can only be selected by one CiliumBGPClusterConfig. However, API-wise it is still possible. Such an error has been reported in the operator's log. This PR introduces a new condition
ConflictingClusterConfigto the CiliumBGPClusterConfig which reports the error in the condition for better trouble shooting experience.Note that this PR removes the
BGPResourceManager node config XXX already existerror we mention in the doc. The corresponding document update will be covered in the separate PR with the description of other conditions we've introduced recently.