Skip to content

iptables: always warn about missing xt_socket module #35591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

iptables: always warn about missing xt_socket module #35591

merged 1 commit into from
Oct 29, 2024

Conversation

julianwiedmann
Copy link
Member

Be consistent in how we treat the xt_socket module - if we attempt to load it, then we should also warn about any error.

@julianwiedmann
iptables: always warn about missing xt_socket module
c830a78 
Be consistent in how we treat the xt_socket module - if we attempt to load
it, then we should also warn about any error.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. area/iptables Impacts how Cilium interacts with iptables. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 28, 2024
@julianwiedmann julianwiedmann requested a review from a team as a code owner October 28, 2024 12:45
@julianwiedmann julianwiedmann requested a review from jibi October 28, 2024 12:45
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 29, 2024
Merged via the queue into cilium:main with commit d8f1fae Oct 29, 2024
70 checks passed
@julianwiedmann julianwiedmann deleted the 1.17-xt-socket branch October 29, 2024 10:45
@joamaki joamaki mentioned this pull request Nov 5, 2024
Merged
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 7, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/iptables Impacts how Cilium interacts with iptables. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @jibi @joamaki