Skip to content

hubble: Add 'release' Make target #35561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Oct 25, 2024

Add hubble release Make target in preparation to the phase 2 of CFP-31893 1 to push hubble CLI release artifacts directly from cilium/cilium repository.

Footnotes

  1. https://github.com/cilium/design-cfps/blob/main/cilium/CFP-31893-move-hubble-into-cilium.md#phase-2-update-the-release-process

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2024
@github-actions github-actions bot added hubble-cli PRs or GitHub issues related with hubble-cli hubble-cli-exclusive Only changes hubble-cli files. labels Oct 25, 2024
@michi-covalent michi-covalent force-pushed the pr/michi/hubble-release branch from 7040d47 to da48d2f Compare October 25, 2024 23:22
@michi-covalent michi-covalent changed the title does this work hubble: Add 'release' Make target Oct 25, 2024
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Oct 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2024
@michi-covalent
Copy link
Contributor Author

/test

Add hubble release Make target in preparation to the phase 2 of
CFP-31893 [^1] to push hubble CLI release artifacts directly from
cilium/cilium repository.

[^1]: https://github.com/cilium/design-cfps/blob/main/cilium/CFP-31893-move-hubble-into-cilium.md#phase-2-update-the-release-process

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent force-pushed the pr/michi/hubble-release branch from da48d2f to 93b781c Compare October 28, 2024 00:54
@michi-covalent
Copy link
Contributor Author

/test

1 similar comment
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent marked this pull request as ready for review October 28, 2024 02:46
@michi-covalent michi-covalent requested a review from a team as a code owner October 28, 2024 02:46
@michi-covalent michi-covalent added this pull request to the merge queue Oct 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 28, 2024
@julianwiedmann julianwiedmann removed this pull request from the merge queue due to a manual request Oct 28, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 985d3d9 Oct 28, 2024
148 of 152 checks passed
@julianwiedmann julianwiedmann deleted the pr/michi/hubble-release branch October 28, 2024 09:59
@michi-covalent
Copy link
Contributor Author

setting backport-1.16 label. we need this in v1.16 branch since we release hubble CLi from the latest stable branch 🚀🙏

@michi-covalent michi-covalent added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 28, 2024
@joamaki joamaki mentioned this pull request Nov 5, 2024
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. hubble-cli PRs or GitHub issues related with hubble-cli hubble-cli-exclusive Only changes hubble-cli files. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants