Skip to content

Conversation

pchaigno
Copy link
Member

The matrix configs for the two IPsec workflows were moved from the workflow themselves to a dedicated file in commit 06cfdb4 ("workflows: Generate IPsec matrix from config file").

We thus need to update the Renovate configuration such that it will know to look in the new, dedicated file with the configs and kernel versions.

Fixes: #35323.

@pchaigno pchaigno added area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. labels Oct 25, 2024
@pchaigno pchaigno marked this pull request as ready for review October 26, 2024 21:56
@pchaigno pchaigno requested review from a team as code owners October 26, 2024 21:56
@pchaigno pchaigno requested a review from brlbil October 26, 2024 21:56
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change likely also needs to adjust the fileMatch stanza here for the file to be matched by the regex manager.

@pchaigno
Copy link
Member Author

Thanks!

The change likely also needs to adjust the fileMatch stanza here for the file to be matched by the regex manager.

Do you mean this one? The one you pointed to already didn't match the IPsec workflows.

@tklauser
Copy link
Member

Thanks!

The change likely also needs to adjust the fileMatch stanza here for the file to be matched by the regex manager.

Do you mean this one? The one you pointed to already didn't match the IPsec workflows.

Ah yes, that's the one I meant to link.

@pchaigno pchaigno force-pushed the fix-renovate-ipsec-workflows branch 2 times, most recently from f8d5cb8 to bacebbc Compare October 29, 2024 12:40
@pchaigno pchaigno requested a review from tklauser October 29, 2024 12:41
The matrix configs for the two IPsec workflows were moved from the
workflow themselves to a dedicated file in commit 06cfdb4
("workflows: Generate IPsec matrix from config file").

We thus need to update the Renovate configuration such that it will know
to look in the new, dedicated file with the configs and kernel versions.

Fixes: 06cfdb4 ("workflows: Generate IPsec matrix from config file")
Reported-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the fix-renovate-ipsec-workflows branch from bacebbc to ef56966 Compare October 29, 2024 12:54
@pchaigno pchaigno enabled auto-merge October 29, 2024 14:05
@pchaigno pchaigno added this pull request to the merge queue Nov 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 4, 2024
Merged via the queue into cilium:main with commit 8560340 Nov 4, 2024
65 checks passed
@pchaigno pchaigno deleted the fix-renovate-ipsec-workflows branch November 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants