Skip to content

bgpv2: set local peering address when specified #35552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

bgpv2: set local peering address when specified #35552

merged 1 commit into from
Oct 29, 2024

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Oct 25, 2024 •
edited
Loading

Set local address for BGP peer based on user provided configuration.

Fixes: #35066

BGPv2: Fixes local address usage via CiliumBGPNodeConfigOverride CRD.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2024
@harsimran-pabla
bgpv2: set local peering address when specified
02d505b 
Set local address for BGP peer based on user provided configuration.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgpv2/node-override-src-ip branch from 269a739 to 02d505b Compare October 25, 2024 18:20
@harsimran-pabla harsimran-pabla added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Oct 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2024
@harsimran-pabla harsimran-pabla added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/bgp Impacts the Border Gateway Protocol feature. labels Oct 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2024
@harsimran-pabla harsimran-pabla marked this pull request as ready for review October 25, 2024 18:24
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner October 25, 2024 18:24
rastislavs
rastislavs approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla harsimran-pabla added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 28, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Oct 29, 2024
Merged via the queue into cilium:main with commit 911ed9f Oct 29, 2024
68 checks passed
@joamaki joamaki mentioned this pull request Nov 5, 2024
Merged
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 7, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CiliumBGPNodeConfigOverride has no effect
4 participants
@harsimran-pabla @rastislavs @joamaki @julianwiedmann