-
Notifications
You must be signed in to change notification settings - Fork 3.4k
cilium: add probe for netkit for more user friendly error when not supported #35551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
Cc @jrife for visibility |
Hmm I wonder if it's worth checking if Edit: then again, this would basically make netkit unusable in the meantime since the agent would just not start up on most kernels people would be using today. |
Hm, for the case of per-endpoint-routes we could actually bail out in that case.. for the non-per-ep-routes we don't need to warn, wdyt? |
That makes sense. |
Ah okay, as I understand, without the patch users would at least have basic connectivity with per-ep-routes, right? If so then yes, we might keep the warning instead. Once the patch hits Linus tree on the next merge win, I'll ping Greg to backport to stable. |
Yes. It's only when you apply network policies that connectivity issues may arise in some cases. |
d4f9e32
to
3e3ff4e
Compare
(CI was green, only changed error text as per @qmonnet's suggestion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a feature probe so that we can warn the user early if netkit is not supported by the underlying kernel. Fixes: #33878 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Add the kernel config option. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
3e3ff4e
to
42c71bb
Compare
/test |
(see commits)