Skip to content

cilium: add probe for netkit for more user friendly error when not supported #35551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

borkmann
Copy link
Member

(see commits)

@borkmann borkmann added release-note/misc This PR makes changes that have no direct user impact. feature/netkit labels Oct 25, 2024
@borkmann borkmann requested a review from rgo3 October 25, 2024 15:59
@borkmann borkmann marked this pull request as ready for review October 25, 2024 15:59
@borkmann borkmann requested review from a team as code owners October 25, 2024 15:59
@borkmann borkmann requested review from jibi, qmonnet and bimmlerd October 25, 2024 15:59
@borkmann
Copy link
Member Author

/test

@borkmann borkmann added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Oct 25, 2024
@borkmann borkmann requested a review from jrife October 25, 2024 16:00
@borkmann
Copy link
Member Author

Cc @jrife for visibility

@jrife
Copy link
Contributor

jrife commented Oct 25, 2024

Hmm I wonder if it's worth checking if SupportsScrub() is true in this probe? We already have a warning if it's not, but I'm thinking users might miss that.

Edit: then again, this would basically make netkit unusable in the meantime since the agent would just not start up on most kernels people would be using today.

@borkmann
Copy link
Member Author

borkmann commented Oct 25, 2024

Hmm I wonder if it's worth checking if SupportsScrub() is true in this probe? We already have a warning if it's not, but I'm thinking users might miss that.

Hm, for the case of per-endpoint-routes we could actually bail out in that case.. for the non-per-ep-routes we don't need to warn, wdyt?

@jrife
Copy link
Contributor

jrife commented Oct 25, 2024

That makes sense.

@borkmann
Copy link
Member Author

Edit: then again, this would basically make netkit unusable in the meantime since the agent would just not start up on most kernels people would be using today.

Ah okay, as I understand, without the patch users would at least have basic connectivity with per-ep-routes, right? If so then yes, we might keep the warning instead. Once the patch hits Linus tree on the next merge win, I'll ping Greg to backport to stable.

@jrife
Copy link
Contributor

jrife commented Oct 25, 2024

Ah okay, as I understand, without the patch users would at least have basic connectivity with per-ep-routes, right?

Yes. It's only when you apply network policies that connectivity issues may arise in some cases.

@borkmann
Copy link
Member Author

(CI was green, only changed error text as per @qmonnet's suggestion)

Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rgo3 rgo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add a feature probe so that we can warn the user early if netkit is not
supported by the underlying kernel.

Fixes: #33878
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Add the kernel config option.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

/test

@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 28, 2024
@borkmann borkmann merged commit 1f5be4a into main Oct 28, 2024
268 of 270 checks passed
@borkmann borkmann deleted the pr/netkit-probe branch October 28, 2024 11:55
@joamaki joamaki mentioned this pull request Nov 5, 2024
23 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 5, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/netkit ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants