Make triggers less garbage intensive #35541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simulates a fast tick rate, but essentially just benchmarks the trigger allocations in the quiescent state, i.e. when not triggered. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Each Trigger which are not triggered would allocate a new time.Timer (via
inctimer.After) on each iteration of the waiter loop. There's no need to
create this much garbage - we can use a ticker instead of the inctimer.
The behaviour is not _exactly_ the same, but the semantics of the
MinInterval and trigger folding are kept intact. As the stdlib docs say,
the ticker adjusts to slow readers. Therefore if the trigger _is_
triggered ofer, and we end up waiting for the MinInterval, the waiter loop is
not run more times due to queued up ticks.
goos: linux
goarch: arm64
pkg: github.com/cilium/cilium/pkg/trigger
│ before.txt │ after.txt │
│ B/op │ B/op vs base │
UntriggeredTrigger-10 11234.5 ± 1% 767.0 ± 11% -93.17% (p=0.000 n=10)
│ before.txt │ after.txt │
│ allocs/op │ allocs/op vs base │
UntriggeredTrigger-10 144.000 ± 1% 8.000 ± 0% -94.44% (p=0.000 n=10)
Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger waiter loop would allocate a
time.Timer(viainctimer.After) persleepInterval(1s) if not triggered, creating a bit of unnecessary garbage for the GC to collect.Please see commit messages - we introduce a benchmark in the first commit, and improve it in the second commit.