Skip to content

bgpv2-docs: updating troubleshooting and operations guide #35431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

bgpv2-docs: updating troubleshooting and operations guide #35431

merged 1 commit into from
Oct 22, 2024

Conversation

harsimran-pabla
Copy link
Contributor

Adding BGPv2 specific details to BGP operations and troubleshooting guide.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 18, 2024
rastislavs
rastislavs approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgpv2/operations-guide branch from cd7817d to 14f9170 Compare October 21, 2024 13:28
@harsimran-pabla harsimran-pabla marked this pull request as ready for review October 21, 2024 13:29
@harsimran-pabla harsimran-pabla requested review from a team as code owners October 21, 2024 13:29
@harsimran-pabla harsimran-pabla requested review from YutaroHayakawa and a user October 21, 2024 13:29
@harsimran-pabla harsimran-pabla added the release-note/misc This PR makes changes that have no direct user impact. label Oct 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 21, 2024
@harsimran-pabla harsimran-pabla added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/bgp Impacts the Border Gateway Protocol feature. labels Oct 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 21, 2024
@harsimran-pabla harsimran-pabla added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 21, 2024
@harsimran-pabla harsimran-pabla removed the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Oct 21, 2024
@harsimran-pabla
bgpv2-docs: updating troubleshooting and operations guide
d135ac0 
Adding BGPv2 specific details to BGP operations and troubleshooting
guide.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgpv2/operations-guide branch from 14f9170 to d135ac0 Compare October 21, 2024 13:42
@harsimran-pabla
Copy link
Contributor Author

/test

YutaroHayakawa
YutaroHayakawa approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new contents looks good to me.

ghost
ghost approved these changes Oct 22, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 22, 2024
@tklauser tklauser added this pull request to the merge queue Oct 22, 2024
Merged via the queue into cilium:main with commit b8465d5 Oct 22, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@rastislavs rastislavs rastislavs approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsimran-pabla @YutaroHayakawa @rastislavs @tklauser