Skip to content

helm: Add priorityClass & nodeSelector to certgen jobs #35429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

helm: Add priorityClass & nodeSelector to certgen jobs #35429

merged 1 commit into from
Oct 21, 2024

Conversation

adberger
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Currently the Helmchart to install Cilium does not allow to set a priorityClassName & nodeSelector for the certgen jobs.
This PR intends to fix this.

helm: Add priorityClass & nodeSelector to certgen jobs

@adberger adberger requested review from a team as code owners October 18, 2024 12:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 18, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 18, 2024
gandro
gandro approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels Oct 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 19, 2024
giorio94
giorio94 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small nit inline.

@giorio94
Copy link
Member

Some automatically generated files seem to be out of sync. You can fix that with:

make -C install/kubernetes
make -C Documentation update-helm-values

@adberger
Copy link
Contributor Author

adberger commented Oct 21, 2024 •
edited
Loading

Some automatically generated files seem to be out of sync. You can fix that with:

make -C install/kubernetes
make -C Documentation update-helm-values

Hmm, unfortunately I get:

make -C install/kubernetes
: cilium/Chart.yaml
grep -lR -e 'version:' -e 'appVersion:' /Users/adberger/cilium/install/kubernetes/cilium/ \
		| xargs -L 1 sed -i -e 's/''\([vV]ersion:\) ''[0-9]\+\.[0-9]\+\.[0-9]\+.*''/\1 '1.17.0-dev'/g'
sed -i 's;icon:.*;icon: https://cdn.jsdelivr.net/gh/cilium/cilium@main/Documentation/images/logo-solo.svg;' "/Users/adberger/cilium/install/kubernetes/cilium/Chart.yaml"
sed: 1: "/Users/adberger/cilium ...": command a expects \ followed by text
make: *** [update-chart] Error 1

I'm on mac, could be a problem.

@adberger @aanm
helm: Add priorityClass & nodeSelector to certgen jobs
4eb229b 
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@aanm
Copy link
Member

aanm commented Oct 21, 2024

/test

@aanm aanm enabled auto-merge October 21, 2024 13:13
@aanm aanm added this pull request to the merge queue Oct 21, 2024
Merged via the queue into cilium:main with commit caa0461 Oct 21, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@giorio94 giorio94 giorio94 approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adberger @giorio94 @aanm @gandro