Skip to content

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Oct 17, 2024

PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied.

Fixes: #31178

PR cilium#31178 added "io.cilium.k8s.policy.cluster" label to default ones
that are propagated even when strict filters are applied.

Fixes: cilium#31178

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel requested review from a team as code owners October 17, 2024 11:36
@marseel marseel requested review from jibi and learnitall October 17, 2024 11:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 17, 2024
@marseel marseel added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch release-note/misc This PR makes changes that have no direct user impact. labels Oct 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 17, 2024
@marseel
Copy link
Contributor Author

marseel commented Oct 17, 2024

/test

Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 21, 2024
@aanm aanm added this pull request to the merge queue Oct 21, 2024
Merged via the queue into cilium:main with commit d3dc7e8 Oct 21, 2024
68 checks passed
@tklauser tklauser mentioned this pull request Oct 22, 2024
10 tasks
@tklauser tklauser added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 22, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 22, 2024
liyihuang added a commit to liyihuang/cilium that referenced this pull request Dec 12, 2024
PR cilium#31178 added "io.cilium.k8s.policy.cluster" label to default ones but
didn't update the doc

PR cilium#35422 added the label in the doc but didn't update the example

Fixes: cilium#31178

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2024
PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but
didn't update the doc

PR #35422 added the label in the doc but didn't update the example

Fixes: #31178

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
pippolo84 pushed a commit that referenced this pull request Dec 16, 2024
[ upstream commit 4b4f45e ]

PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but
didn't update the doc

PR #35422 added the label in the doc but didn't update the example

Fixes: #31178

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84 pushed a commit that referenced this pull request Dec 19, 2024
[ upstream commit 4b4f45e ]

PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but
didn't update the doc

PR #35422 added the label in the doc but didn't update the example

Fixes: #31178

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84 pushed a commit that referenced this pull request Dec 19, 2024
[ upstream commit 4b4f45e ]

PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but
didn't update the doc

PR #35422 added the label in the doc but didn't update the example

Fixes: #31178

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 23, 2024
[ upstream commit 4b4f45e ]

PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but
didn't update the doc

PR #35422 added the label in the doc but didn't update the example

Fixes: #31178

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants