Skip to content

cilium-operator: fix datasource Prometheus for Grafana dashboard #35420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

cilium-operator: fix datasource Prometheus for Grafana dashboard #35420

merged 1 commit into from
Oct 21, 2024

Conversation

VergeDX
Copy link
Contributor

@VergeDX VergeDX commented Oct 17, 2024 •
edited
Loading

Fixes: #35335

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #35335

Datasource error fixed for Cilium Operator dashboard

@VergeDX
cilium-operator: fix datasource Prometheus for Grafana dashboard
b89f54e 
Fixes: cilium#35335

Signed-off-by: Vanilla <osu_Vanilla@126.com>
@VergeDX VergeDX requested review from a team as code owners October 17, 2024 09:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 17, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 17, 2024
@squeed squeed added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Oct 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 17, 2024
@squeed
Copy link
Contributor

squeed commented Oct 17, 2024

@VergeDX, would you mind writing a small release-note? Something like "fixes an invalid datasource value in the Operator Grafana dashboards for Grafana versions XXX+"

Thanks!

@VergeDX
Copy link
Contributor Author

VergeDX commented Oct 18, 2024

@VergeDX, would you mind writing a small release-note? Something like "fixes an invalid datasource value in the Operator Grafana dashboards for Grafana versions XXX+"

Thanks!

Updated! I added a release note by following PR 30580.

@gandro gandro added the area/metrics Impacts statistics / metrics gathering, eg via Prometheus. label Oct 19, 2024
@gandro
Copy link
Member

gandro commented Oct 19, 2024

/test

@aanm aanm added this pull request to the merge queue Oct 21, 2024
Merged via the queue into cilium:main with commit 6cda71d Oct 21, 2024
73 checks passed
@joestringer
Copy link
Member

Thanks for the fix @VergeDX :)

@VergeDX VergeDX deleted the patch-1 branch October 22, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/community-contribution This was a contribution made by a community member. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium Operator dashboard doesn't work
5 participants
@VergeDX @squeed @gandro @joestringer @aanm