Skip to content

Conversation

antonipp
Copy link
Contributor

@antonipp antonipp commented Oct 17, 2024

Backport #34090 to 1.15

A couple of notes:

I tested the backport in our cluster running 1.15 and confirmed that "Unable to compute pending pods, will not surge-allocate" warnings were gone.

34090

@antonipp antonipp requested a review from a team as a code owner October 17, 2024 08:46
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Oct 17, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 17, 2024
[ upstream commit c3db8a5 ]

Fixes cilium#32713

PodNodeNameIndex is added to the Pod watcher in operatorK8s.Resource.

This will be refactored once `ciliumNodeSynchronizer` is migrated to a cell.

Signed-off-by: Dorde Lapcevic <dordel@google.com>
Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
@antonipp antonipp force-pushed the ai/backport-pr-34090-1-15 branch from 5d1fe6d to a90d47b Compare October 17, 2024 09:24
@squeed squeed requested a review from dlapcevic October 17, 2024 11:21
@dlapcevic
Copy link
Contributor

Thank you @antonipp!

@qmonnet
Copy link
Member

qmonnet commented Oct 18, 2024

/test-backport-1.15

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 18, 2024
@pchaigno
Copy link
Member

@dlapcevic @antonipp FYI, #34090 (comment). Could we fix this before we go and release this patch in another version without a proper release note?

@dlapcevic
Copy link
Contributor

Looks good to me. I think we can move forward with merging it.

@antonipp please confirm.

@antonipp
Copy link
Contributor Author

I added a release note to my PR to indicate that a bug was fixed. I don't have rights to change the labels on the PR though.
(By the way, it's clearly fixing a bug with user impact)

@aanm aanm added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Oct 21, 2024
@aanm aanm merged commit 940824e into cilium:v1.15 Oct 21, 2024
61 checks passed
@pchaigno
Copy link
Member

I added a release note to my PR to indicate that a bug was fixed. I don't have rights to change the labels on the PR though. (By the way, it's clearly fixing a bug with user impact)

I believe the release note and label need to be on the upstream PR. I'm unsure what effect they would have on the backport PR. AFAIK, we derive release notes for backport PRs from the upstream PR.

@antonipp
Copy link
Contributor Author

Ok, I didn't know it worked this way, I will let Dorde update the original PR then.

@pchaigno
Copy link
Member

cc @dlapcevic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants