Skip to content

gha: Remove hostLegacyRouting in clustermesh #35418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

gha: Remove hostLegacyRouting in clustermesh #35418

merged 1 commit into from
Oct 28, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 17, 2024 •
edited
Loading

Relates: #35098
Fixes: #31653

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 17, 2024
@sayboras
Copy link
Member Author

/ci-clustermesh

@sayboras sayboras force-pushed the pr/tammach/test-dummy branch from 4bcb156 to b48d0b0 Compare October 26, 2024 10:53
@sayboras
Copy link
Member Author

/ci-clustermesh

@sayboras sayboras force-pushed the pr/tammach/test-dummy branch from b48d0b0 to 933eb4f Compare October 27, 2024 09:40
@maintainer-s-little-helper
Copy link

Commit f399b2c does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 27, 2024
@sayboras
Copy link
Member Author

/ci-clustermesh

@sayboras sayboras force-pushed the pr/tammach/test-dummy branch from 933eb4f to 0f8f73f Compare October 27, 2024 10:00
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 27, 2024
@sayboras sayboras changed the title dummy testing gha: Remove hostLegacyRouting in clustermesh Oct 27, 2024
@sayboras sayboras added release-note/misc This PR makes changes that have no direct user impact. feature/k8s-gateway-api feature/k8s-ingress labels Oct 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 27, 2024
@sayboras
Copy link
Member Author

/ci-clustermesh

@sayboras sayboras mentioned this pull request Oct 27, 2024
Merged
@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch backport/author The backport will be carried out by the author of the PR. and removed release-note/misc This PR makes changes that have no direct user impact. labels Oct 27, 2024
@sayboras
gha: Remove hostLegacyRouting in clustermesh
3bfa5c6 
Relates: #35098
Fixes: #31653

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/test-dummy branch from 0f8f73f to 3bfa5c6 Compare October 28, 2024 13:35
@sayboras
Copy link
Member Author

/ci-clustermesh

@sayboras sayboras marked this pull request as ready for review October 28, 2024 13:35
@sayboras sayboras requested review from a team as code owners October 28, 2024 13:35
@sayboras sayboras requested review from a team as code owners October 28, 2024 13:35
giorio94
giorio94 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayboras
Copy link
Member Author

/test

@sayboras sayboras enabled auto-merge October 28, 2024 14:02
@sayboras sayboras added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 78e8f73 Oct 28, 2024
96 checks passed
@sayboras sayboras deleted the pr/tammach/test-dummy branch October 28, 2024 14:53
@julianwiedmann julianwiedmann mentioned this pull request Oct 29, 2024
Merged
@julianwiedmann
Copy link
Member

@sayboras if you still want to tackle the v1.16 backport, I think the needed pre-reqs are all in now 🎉

@sayboras
Copy link
Member Author

sayboras commented Dec 4, 2024

if you still want to tackle the v1.16 backport, I think the needed pre-reqs are all in now 🎉

Thanks for reminding me, I am doing now :typing:

@sayboras sayboras mentioned this pull request Dec 4, 2024
Merged
1 task
@sayboras sayboras added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 4, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 9, 2024
@sayboras sayboras mentioned this pull request Dec 11, 2024
Closed
2 tasks
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@giorio94 giorio94 giorio94 approved these changes

@youngnick youngnick Awaiting requested review from youngnick youngnick is a code owner automatically assigned from cilium/sig-servicemesh

@brlbil brlbil Awaiting requested review from brlbil brlbil is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/k8s-gateway-api feature/k8s-ingress release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pod to ingress with backend hosted on the same node not working in certain configurations
4 participants
@sayboras @julianwiedmann @qmonnet @giorio94