Skip to content

.github: remove libncurses5 from integration tests #35408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

.github: remove libncurses5 from integration tests #35408

merged 1 commit into from
Oct 16, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Oct 15, 2024

This package was added in 7a301a4 ("introduce ARM github workflows") and it's no longer being used so we can remove it as it's not available in ubuntu-latest (24.04).

@aanm
.github: remove libncurses5 from integration tests
9456afd 
This package was added in 7a301a4 ("introduce ARM github workflows")
and it's no longer being used so we can remove it as it's not available
in ubuntu-latest (24.04).

Signed-off-by: André Martins <andre@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@aanm aanm added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 15, 2024
@aanm
Copy link
Member Author

aanm commented Oct 15, 2024

/test

@aanm aanm marked this pull request as ready for review October 15, 2024 21:29
@aanm aanm requested review from a team as code owners October 15, 2024 21:29
@aanm aanm requested a review from brlbil October 15, 2024 21:29
@aanm aanm enabled auto-merge October 15, 2024 21:29
@aanm aanm added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 63cd391 Oct 16, 2024
76 checks passed
@aanm aanm deleted the pr/remove-libncurses5 branch October 16, 2024 02:16
@tklauser tklauser mentioned this pull request Oct 22, 2024
Merged
10 tasks
@tklauser tklauser added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 22, 2024
@tklauser tklauser mentioned this pull request Oct 22, 2024
Merged
4 tasks
@tklauser tklauser added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Oct 22, 2024
@tklauser tklauser mentioned this pull request Oct 22, 2024
Merged
5 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Oct 22, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 22, 2024
@tklauser
Copy link
Member

It looks like backporting this to v1.14 and v1.15 leads to the integration tests failing with:

  CC     bpf/bpf_lxc.o
clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
make[1]: *** [Makefile:241: bpf_lxc.o] Error 127
make: *** [Makefile:82: bpf] Error 2
make: *** Waiting for unfinished jobs....

(see e.g. https://github.com/cilium/cilium/actions/runs/11459738817/job/31884905163)

This is due to the fact that these branches still use llvm 10 while main and v1.16 use newer versions. It looks like llvm 10 is still linked against libtinfo.so.5 so we somehow need to installed that shared lib. I guess a manual fix is needed for v1.14 and v1.15, e.g. by pinning the runner version to ubuntu-22.04 instead of ubuntu-latest so we can still install libncurses5.

@tklauser tklauser added backport/author The backport will be carried out by the author of the PR. needs-backport/1.14 and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Oct 23, 2024
@aanm aanm removed needs-backport/1.15 backport/author The backport will be carried out by the author of the PR. labels Oct 23, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

@sayboras sayboras sayboras approved these changes

@brlbil brlbil Awaiting requested review from brlbil brlbil is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aanm @tklauser @mhofstetter @sayboras