Skip to content

golang: Enable type alias again for go 1.23 #35406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2024
Merged

golang: Enable type alias again for go 1.23 #35406

merged 2 commits into from
Nov 28, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 15, 2024 •
edited
Loading

All files are re-generated again as there is a change in generation tools.

Relates: kubernetes/kubernetes#127271
Relates: cilium/deepequal-gen#7
Relates: kubernetes-sigs/controller-tools#1061
Relates: 1d9d51f

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@sayboras sayboras mentioned this pull request Oct 15, 2024
Closed
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Oct 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch 3 times, most recently from 5183204 to 6da4707 Compare October 16, 2024 08:27
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 6da4707 to 462f104 Compare October 16, 2024 12:17
@sayboras
Copy link
Member Author

/test

chaunceyjiang
chaunceyjiang reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

here

@sayboras
Copy link
Member Author

here

Oops, good catch 👍

@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 462f104 to 941619a Compare October 17, 2024 02:59
@sayboras
Copy link
Member Author

/test

@sayboras sayboras added the dont-merge/preview-only Only for preview or testing, don't merge it. label Oct 18, 2024
@sayboras sayboras marked this pull request as ready for review October 18, 2024 12:20
@sayboras sayboras requested review from a team as code owners October 18, 2024 12:20
sayboras
sayboras commented Oct 18, 2024
View reviewed changes
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 941619a to 3b46994 Compare October 19, 2024 06:23
@aanm aanm self-requested a review October 21, 2024 08:02
@sayboras sayboras marked this pull request as draft October 21, 2024 10:45
@sayboras
Copy link
Member Author

Convert to draft as it's better to wait for 1.32 RC.

@aanm aanm added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit c0e6151 Nov 28, 2024
284 checks passed
@aanm aanm deleted the pr/tammach/enable-type-alias branch November 28, 2024 11:17
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 28, 2024
sayboras added a commit that referenced this pull request Nov 28, 2024
@sayboras
k8s: Add support for 1.32.0
9cbce9f 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Nov 28, 2024
Merged
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
a0373ce 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
9b0e315 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
0d4fe50 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
0a13867 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

One point worth noting is the test combination between k8s version and
kernel is shifted from 1.31 -> 1.32, 1.30 -> 1.31, 1.29 -> 1.30
respectively, so that we are still having the same coverage.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
eb69388 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

One point worth noting is the test combination between k8s version and
kernel is shifted from 1.31 -> 1.32, 1.30 -> 1.31, 1.29 -> 1.30
respectively, so that we are still having the same coverage.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
28400ea 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

One point worth noting is the test combination between k8s version and
kernel is shifted from 1.31 -> 1.32, 1.30 -> 1.31, 1.29 -> 1.30
respectively, so that we are still having the same coverage.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Nov 29, 2024
@sayboras
k8s: Add support for 1.32.0
133460e 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

One point worth noting is the test combination between k8s version and
kernel is shifted from 1.31 -> 1.32, 1.30 -> 1.31, 1.29 -> 1.30
respectively, so that we are still having the same coverage.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Dec 2, 2024
@sayboras
k8s: Add support for 1.32.0
706b168 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

One point worth noting is the test combination between k8s version and
kernel is shifted from 1.31 -> 1.32, 1.30 -> 1.31, 1.29 -> 1.30
respectively, so that we are still having the same coverage.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2024
@sayboras @aanm
k8s: Add support for 1.32.0
e471a29 
Most of the dependencies are updated as part of the below PR. This
commit is to cover the rest to support k8s 1.32.

One point worth noting is the test combination between k8s version and
kernel is shifted from 1.31 -> 1.32, 1.30 -> 1.31, 1.29 -> 1.30
respectively, so that we are still having the same coverage.

Relates: #35406
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras pushed a commit that referenced this pull request Mar 19, 2025
@ferozsalam @sayboras
[v1.16] Bump x/net
27592a3 
This closes off GHSA-qxp5-gwg8-xv66

Just a note that go 1.23 type alias breaks controller-tools code
generation, so gotypesalias=0 is set to keep the same behavior in go
1.22.

Relates: kubernetes-sigs/controller-tools#1078
Relates: #35406

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Mar 19, 2025
Merged
ferozsalam added a commit that referenced this pull request Mar 20, 2025
@ferozsalam
[v1.16] Bump x/net
0a8c42d 
This closes off GHSA-qxp5-gwg8-xv66

Just a note that go 1.23 type alias breaks controller-tools code
generation, so gotypesalias=0 is set to keep the same behavior in go
1.22.

Relates: kubernetes-sigs/controller-tools#1078
Relates: #35406

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
ferozsalam added a commit that referenced this pull request Mar 20, 2025
@ferozsalam @sayboras
Bump x/net
8c2ccb2 
This resolves GHSA-qxp5-gwg8-xv66

Just a note that go 1.23 type alias breaks controller-tools code
generation, so gotypesalias=0 is set to keep the same behavior in go
1.22.

Relates: kubernetes-sigs/controller-tools#1078
Relates: #35406

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
Co-authored-by: Tam Mach <tam.mach@cilium.io>
@ferozsalam ferozsalam mentioned this pull request Mar 20, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 20, 2025
@ferozsalam @joestringer
[v1.16] Bump x/net
67e85eb 
This closes off GHSA-qxp5-gwg8-xv66

Just a note that go 1.23 type alias breaks controller-tools code
generation, so gotypesalias=0 is set to keep the same behavior in go
1.22.

Relates: kubernetes-sigs/controller-tools#1078
Relates: #35406

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
ferozsalam added a commit that referenced this pull request Mar 21, 2025
@ferozsalam @sayboras
Bump x/net
9a6a30d 
This resolves GHSA-qxp5-gwg8-xv66

Just a note that go 1.23 type alias breaks controller-tools code
generation, so gotypesalias=0 is set to keep the same behavior in go
1.22.

Relates: kubernetes-sigs/controller-tools#1078
Relates: #35406

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
Co-authored-by: Tam Mach <tam.mach@cilium.io>
julianwiedmann pushed a commit that referenced this pull request Mar 21, 2025
@ferozsalam @sayboras @julianwiedmann
Bump x/net
22e8a09 
This resolves GHSA-qxp5-gwg8-xv66

Just a note that go 1.23 type alias breaks controller-tools code
generation, so gotypesalias=0 is set to keep the same behavior in go
1.22.

Relates: kubernetes-sigs/controller-tools#1078
Relates: #35406

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
Co-authored-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@tklauser tklauser tklauser approved these changes

@brlbil brlbil brlbil approved these changes

@aanm aanm aanm approved these changes

+1 more reviewer

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sayboras @nathanjsweet @tklauser @brlbil @aanm @chaunceyjiang