Skip to content

policy: Add config for enabling Cilium Clusterwide Network Policy #35405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

policy: Add config for enabling Cilium Clusterwide Network Policy #35405

merged 1 commit into from
Oct 28, 2024

Conversation

dlapcevic
Copy link
Contributor

@dlapcevic dlapcevic commented Oct 15, 2024 •
edited
Loading

Related to modularizing network policies: #33360

Previous config change that includes both CNP and CCNP in the same flag: #35049

Signed-off-by: Dorde Lapcevic <dordel@google.com>

@dlapcevic dlapcevic requested review from a team as code owners October 15, 2024 13:55
@dlapcevic dlapcevic requested a review from tklauser October 15, 2024 13:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@dlapcevic dlapcevic requested a review from youngnick October 15, 2024 13:55
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Oct 15, 2024
@dlapcevic dlapcevic added the release-note/misc This PR makes changes that have no direct user impact. label Oct 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@dlapcevic
Copy link
Contributor Author

Adding folks with context, who reviewed the previous PR for adding config for CNP. #35049

cc @doniacld @sypakine @ovidiutirla @joamaki

@dlapcevic
policy: Add config for enabling Cilium Clusterwide Network Policy
a252367 
Related to modularizing network policies: cilium#33360

Signed-off-by: Dorde Lapcevic <dordel@google.com>
@dlapcevic
Copy link
Contributor Author

/test

sypakine
sypakine approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@sypakine sypakine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: changes to flag behavior are functional (and sometimes breaking). In the future, consider how to keep the flag behavior consistent.

OK from me as this is a dev branch and the commits are not a candidate for backport.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 24, 2024
@aanm aanm merged commit 3b294e9 into cilium:main Oct 28, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@youngnick youngnick youngnick approved these changes

+1 more reviewer

@sypakine sypakine sypakine approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlapcevic @tklauser @sypakine @youngnick @aanm