endpoint: make restore-rules caching private #35488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when DNS proxy redirects were deleted, we would also clear the special DNS rule cache. (The rule cache is so we can serve DNS traffic while endpoints are being restored on agent restart). However, now that redirects can only be changed during regeneration, and we always set the DNS rules directly during regen, we no longer need this callback. So, clean up the interfaces. While we're at it, pass the endpoint ID as needed instead of the full endpoint. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
|
/test |
doniacld
approved these changes
Oct 28, 2024
jrajahalme
approved these changes
Nov 4, 2024
|
/ci-gateway-api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when DNS proxy redirects were deleted, we would also clear the special DNS rule cache. (The rule cache is so we can serve DNS traffic while endpoints are being restored on agent restart). However, now that redirects can only be changed during regeneration, and we always set the DNS rules directly during regen, we no longer need this callback.
So, clean up the interfaces. While we're at it, pass the endpoint ID as needed instead of the full endpoint.