Skip to content

Update values.yaml to include iptablesRandomFully #35484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

Update values.yaml to include iptablesRandomFully #35484

merged 1 commit into from
Nov 5, 2024

Conversation

rbankston
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Update values file to include flag iptablesRandomFully.
Documentation for: #13037

Update values file to include flag iptablesRandomFully

@rbankston rbankston requested review from a team as code owners October 22, 2024 15:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 22, 2024
@rbankston rbankston requested a review from gandro October 22, 2024 15:59
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 22, 2024
@tommyp1ckles
Copy link
Contributor

/test

gandro
gandro approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels Oct 23, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 23, 2024
@gandro
Copy link
Member

gandro commented Oct 23, 2024

Seems like CI is unhappy due to the docs not being regenerated. Please run make -C Documentation update-helm-values and squash the changes into the existing commit. Thanks!

@derailed
Copy link
Contributor

@rbankston When you get a chance, could you update the docs as per @gandro suggestion? Thank you!

@rbankston rbankston force-pushed the addIptablesRandomFullyValue branch from 42b89bf to ed9b1fa Compare October 30, 2024 15:56
@gandro
Copy link
Member

gandro commented Oct 30, 2024

The commit message has a double sign-off, which is why the Check Patch workflow is failing. Use git commit --amend to fix

@rbankston rbankston force-pushed the addIptablesRandomFullyValue branch from ed9b1fa to 9e34a2d Compare October 31, 2024 15:09
@rbankston
Copy link
Contributor Author

Thank you.

@gandro
Copy link
Member

gandro commented Oct 31, 2024

/test

@gandro gandro enabled auto-merge October 31, 2024 15:33
@maintainer-s-little-helper
Copy link

Commit 4db4fdf does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 31, 2024
@aanm
Updated values.yaml to include configuration values for cilium#13037
33842e0 
Signed-off-by: Ralph Bankston <ralph@isovalent.com>
@aanm aanm force-pushed the addIptablesRandomFullyValue branch from 4db4fdf to 33842e0 Compare November 4, 2024 10:33
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 4, 2024
@aanm
Copy link
Member

aanm commented Nov 4, 2024

/test

@gandro gandro added this pull request to the merge queue Nov 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 5, 2024
Merged via the queue into cilium:main with commit d7884f5 Nov 5, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbankston @tommyp1ckles @gandro @derailed @aanm