Add support for automatic port-forwarding in Hubble CLI #35483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devodev
commented
Oct 22, 2024
8 tasks
1394e17 to
3a0885f
Compare
chancez
reviewed
Oct 22, 2024
chancez
approved these changes
Oct 22, 2024
|
/test |
|
@chancez i guess we can remove |
0983d85 to
24a858c
Compare
|
Fixed the go mod/vendor check with my latest force-push |
|
/test |
|
The hubble-cli compile test started failing on 32bit platform after the latest rebase. Opened a PR for a fix attempt. |
chancez
approved these changes
Oct 30, 2024
…dutils Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
Add a new type that provides helper methods for kubernetes port-forwarding which is not linked to the cilium-cli k8s client to allow re-use. Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
Add a new helper method that finds the best candidate pod for port-forwrding using a service reference. Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
Add the capability to connect to hubble relay by creating a port-forward to the appropriate pod similar to manually spawning a new process with 'cilium hubble port-forward'. Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
Replace kubectl-based port-forwarding with a native implementation inspired by the kubectl port-forward cmd introduced by the PortForwarder helper type. Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
auto-merge was automatically disabled
October 31, 2024 13:10
Head branch was pushed to by a user without write access
24a858c to
771193d
Compare
|
Fix PR has been merged and I force pushed a rebase from main. @michi-covalent would you be kind enough to re-trigger tests when you can? 🥺 Thank you! |
|
/test |
|
That IPSec test is very flaky from looking at the action history. Hopefully a re-trigger will have it go through 🤞 |
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Nov 6, 2024
Update workflow files to accommodate cilium/cilium#35483. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Nov 6, 2024
Update workflow files to accommodate cilium/cilium#35483. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement automatic (opt-in) port-forwarding capability in Hubble-cli.
As proposed in #35353, this uses native port-forwarding by introducing a new high-level PortForwarder type to add automatic port-forwarding to all commands that require a GRPC connection to hubble-relay.
Fixes: #34935
This also updates hubble port-forwarding commands in cilium-cli to replace the kubectl-based implementation, but we can also do that in a different PR if desired. Added bonus is we don't need to sleep in a goroutine before opening the browser to mitigate the kubectl spawn process delay, nice.