Skip to content

Add Koyeb to users.md #35481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add Koyeb to users.md #35481

merged 1 commit into from
Oct 23, 2024

Conversation

alisdairbr
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Add Koyeb to list of Cilium users

@alisdairbr alisdairbr requested a review from a team as a code owner October 22, 2024 14:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 22, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 22, 2024
@maintainer-s-little-helper
Copy link

Commit 5e2bb70 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 22, 2024
@xmulligan
Copy link
Member

Sorry hit approve without refreshing. You didn't need to do the merge commit because now that one isn't signed off. It was all correct until then.

@xmulligan xmulligan self-requested a review October 22, 2024 15:22
@alisdairbr
Add Koyeb to users.md
e59b17c 
Signed-off-by: alisdairbr <alisdairbr@users.noreply.github.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 23, 2024
@alisdairbr
Copy link
Contributor Author

Ok, should be good now! :)

@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Oct 23, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2024
@xmulligan
Copy link
Member

Perfect, thanks!

@xmulligan
Copy link
Member

/test

@xmulligan xmulligan enabled auto-merge October 23, 2024 13:47
@xmulligan xmulligan added this pull request to the merge queue Oct 23, 2024
Merged via the queue into cilium:main with commit abc7550 Oct 23, 2024
63 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmulligan xmulligan xmulligan approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisdairbr @xmulligan