Skip to content

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Oct 22, 2024

This PR adds a "k8s" script command and reimplements the k8s integration test-suite in pkg/loadbalancer/experimental as script tests.

StateDB is bumped to v0.3.2 to fix the column ordering bug.

@joamaki joamaki requested review from a team as code owners October 22, 2024 12:06
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 22, 2024
@joamaki
Copy link
Contributor Author

joamaki commented Oct 22, 2024

/test

@joamaki joamaki requested a review from ovidiutirla October 22, 2024 12:07
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Oct 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 22, 2024
@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from 014fa44 to 2e8198e Compare October 22, 2024 12:09
@joamaki
Copy link
Contributor Author

joamaki commented Oct 22, 2024

/test

@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from 2e8198e to 378f242 Compare October 23, 2024 07:35
@maintainer-s-little-helper

This comment was marked as resolved.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 23, 2024
@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from 378f242 to b1024a5 Compare October 23, 2024 07:36
@maintainer-s-little-helper

This comment was marked as resolved.

@joamaki
Copy link
Contributor Author

joamaki commented Oct 23, 2024

/test

Copy link
Contributor

@ovidiutirla ovidiutirla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ovidiutirla
Copy link
Contributor

/cc @DamianSawicki

@DamianSawicki
Copy link
Contributor

/cc @DamianSawicki

Jussi already mentioned this to me on Slack, but thanks for remembering to let me know @ovidiutirla! I'll try to have a look.

@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from b1024a5 to f655dbe Compare October 25, 2024 09:20
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 25, 2024
@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from f655dbe to 70554d7 Compare October 25, 2024 09:23
The API resource definitions used by test/controlplane for detecting
capabilities are usable in other contexts. Move them to the testutils
package.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from 70554d7 to 7c83fc7 Compare October 25, 2024 12:47
Add the "k8s" script command for interacting with the client-go fake clientset.
Example usage in txtar:

  k8s add foo.yaml bar.yaml
  k8s update foo2.yaml
  k8s delete foo2.yaml bar.yaml

  -- foo.yaml --
  apiVersion: v1
  ...

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
As things are maturing, switch most of the logging from Info to Debug.
Remove the unused logger from Writer.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Since we don't need to retry Resource[T] events in the reflector,
mark the events as handled right away. This way the reflector can
be stopped at any point with unhandled objects in the buffer without
causing the event finalizer to panic due to uncalled Done().

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Add scripttest runner

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Test for checking that unexpected BPF map contents are pruned when tables are empty.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Now that tests have been converted to scripttest drop the old test suite.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/hivescript-load-balancing branch from 7c83fc7 to bc7ab64 Compare October 25, 2024 12:52
@joamaki
Copy link
Contributor Author

joamaki commented Oct 25, 2024

/test

Copy link
Contributor

@DamianSawicki DamianSawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes and explanations!

@joamaki joamaki enabled auto-merge October 29, 2024 09:27
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got two nits, looks good to me otherwise

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 29, 2024
@joamaki joamaki added this pull request to the merge queue Oct 29, 2024
Merged via the queue into cilium:main with commit 985d66c Oct 29, 2024
64 checks passed
@joamaki joamaki deleted the pr/joamaki/hivescript-load-balancing branch October 29, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants