-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Reimplement experimental load-balancing tests in scripttest #35480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement experimental load-balancing tests in scripttest #35480
Conversation
/test |
014fa44
to
2e8198e
Compare
/test |
2e8198e
to
378f242
Compare
This comment was marked as resolved.
This comment was marked as resolved.
378f242
to
b1024a5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/cc @DamianSawicki |
Jussi already mentioned this to me on Slack, but thanks for remembering to let me know @ovidiutirla! I'll try to have a look. |
b1024a5
to
f655dbe
Compare
f655dbe
to
70554d7
Compare
The API resource definitions used by test/controlplane for detecting capabilities are usable in other contexts. Move them to the testutils package. Signed-off-by: Jussi Maki <jussi@isovalent.com>
70554d7
to
7c83fc7
Compare
Add the "k8s" script command for interacting with the client-go fake clientset. Example usage in txtar: k8s add foo.yaml bar.yaml k8s update foo2.yaml k8s delete foo2.yaml bar.yaml -- foo.yaml -- apiVersion: v1 ... Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
As things are maturing, switch most of the logging from Info to Debug. Remove the unused logger from Writer. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Since we don't need to retry Resource[T] events in the reflector, mark the events as handled right away. This way the reflector can be stopped at any point with unhandled objects in the buffer without causing the event finalizer to panic due to uncalled Done(). Signed-off-by: Jussi Maki <jussi@isovalent.com>
Add scripttest runner Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Test for checking that unexpected BPF map contents are pruned when tables are empty. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Now that tests have been converted to scripttest drop the old test suite. Signed-off-by: Jussi Maki <jussi@isovalent.com>
7c83fc7
to
bc7ab64
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes and explanations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got two nits, looks good to me otherwise
This PR adds a "k8s" script command and reimplements the k8s integration test-suite in
pkg/loadbalancer/experimental
as script tests.StateDB is bumped to v0.3.2 to fix the column ordering bug.