Skip to content

ipam: lower severity of first CiliumNode failed update #35479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

ipam: lower severity of first CiliumNode failed update #35479

merged 1 commit into from
Oct 28, 2024
+20 −23

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Oct 22, 2024

When we try to update ipam information in CiliumNode, whenever node
information is outdated we were logging a warning. Succeeding update
operation with fresh node information is usually successful though.
Still, exceesive warning might be confusing to our users.
From now on, log warning only if all retries failed.

Related: #35404

ipam: lower the severity of failed cilium node update if retry is going to be performed immediately

@marseel
ipam: lower severity of first CiliumNode failed update
26c4555 
When we try to update ipam information in CiliumNode, whenever node
information is outdated we were logging a warning. Succeeding update
operation with fresh node information is usually successful though.
Still, exceesive warning might be confusing to our users.
From now on, log warning only if all retries failed.

Related: #35404

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/ipam area/ipam IP address management, including cloud IPAM labels Oct 22, 2024
@marseel marseel mentioned this pull request Oct 22, 2024
Open
3 tasks
@marseel
Copy link
Contributor Author

marseel commented Oct 22, 2024

/test

@marseel marseel marked this pull request as ready for review October 23, 2024 15:09
@marseel marseel requested a review from a team as a code owner October 23, 2024 15:09
@marseel marseel requested a review from pippolo84 October 23, 2024 15:09
pippolo84
pippolo84 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 24, 2024
@aanm aanm merged commit a861faa into main Oct 28, 2024
260 checks passed
@aanm aanm deleted the pr/marseel/fix_ipam_warnings branch October 28, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pippolo84 pippolo84 pippolo84 approved these changes

Assignees
No one assigned
Labels
area/ipam IP address management, including cloud IPAM ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marseel @pippolo84 @aanm