bpf: nodeport: split off the egress-specific parts #35474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cda870b to
a681205
Compare
|
/test |
This picks up a suggestion by Timo in cilium#30334 (comment) to split the big nodeport.h file into ingress/egress specific parts, so that they can be included separately. This helps the XDP program, where we don't need any of the egress code - but currently still compile the tailcalls and then prune them out at load time. Having ingress/egress parts also makes it much easier to understand the code flow. To reduce the churn for now this patch only isolates the egress parts, while nodeport.h contains the ingress *and* shared parts. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
a681205 to
e514148
Compare
|
/test |
jschwinger233
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up a suggestion by Timo in
#30334 (comment) to split the big nodeport.h file into ingress/egress specific parts, so that they can be included separately. This helps the XDP program, where we don't need any of the egress code - but currently still compile the tailcalls and then prune them out at load time. Having ingress/egress parts also makes it much easier to understand the code flow.
To reduce the churn for now this patch only isolates the egress parts, while nodeport.h contains the ingress and shared parts.