v1.15 Backports 2024-10-22 #35469
Merged
v1.15 Backports 2024-10-22 #35469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-backport-1.15 |
mhofstetter
approved these changes
Oct 22, 2024
sayboras
approved these changes
Oct 22, 2024
|
Integration tests are failing with: I assume this is related to that PR? |
|
/ci-integration |
aanm
approved these changes
Oct 22, 2024
aanm
reviewed
Oct 22, 2024
aanm
requested changes
Oct 22, 2024
[ upstream commit 9c1ef94 ] Currently, failing attempts to obtain the eni link list while waiting for net link devices are logged as error. This leads to CI flakes due to the check `check-log-errors` in our test suite. ``` ❌ Found 1 logs in cilium-cilium-9121495685-1.us-west-1.eksctl.io/kube-system/cilium-vkddg (cilium-agent) matching list of errors that must be investigated: time="2024-05-17T01:39:54Z" level=error msg="failed to obtain eni link list" error="interrupted system call" subsys=ipam (1 occurrences) ``` Recent changes included this failure into the existing retry loop. Therefore it would be sufficient to log this failure as warning (instead of an error). Exceeding the retries would result in an error anyway. Therefore, this commit lowers the loglevel from `error` to `warn` and improves the log message by indicating the retry. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit a26427b ] This is to avoid the below failure while chmod-ing symlink. ``` chmod: cannot operate on dangling symlink '/usr/local/bin/now' ``` Sample run: https://github.com/cilium/cilium/actions/runs/11343796440/job/31547213730?pr=35397 Signed-off-by: Tam Mach <tam.mach@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit e08929b ] The jq flag 'argfile' has been removed. The solution is to use slurpfile instead. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit f269eee ] It is useful to keep the image digests as long as possible, thus this commit removes the retention period of 10 days. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
8570199 to
bf94fd0
Compare
|
/test-backport-1.15 |
aanm
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs skipped due to conflicts:
Once this PR is merged, a GitHub action will update the labels of these PRs: