-
Notifications
You must be signed in to change notification settings - Fork 3.4k
v1.16 Backports 2024-10-22 #35468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.16 Backports 2024-10-22 #35468
Conversation
[ upstream commit 0a9d63f ] Previously, neighbor-link-updater set the health status error for each neighboring node to a concatenation of all errors from all nodes processed so far. Fix it by storing only the error from refreshing the particular node. Signed-off-by: Will Daly <widaly@microsoft.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit ed34095 ] Signed-off-by: Gilberto Bertin <jibi@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit abdaddc ] When redirecting from a L3 device to the overlay interface, we need to manually add a L2 header to the (inner) packet. #33421 fixed this for the case of Nodeport NAT traffic from the LB node to a backend. Generalize it so that it helps all users of the nodeport_add_tunnel_encap() helper - for example DSR-Geneve or EgressGW reply traffic. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 677bcc1 ] Validate that the from-netdev program adds a L2 header to the packet, before redirecting it to the overlay interface. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit a26427b ] This is to avoid the below failure while chmod-ing symlink. ``` chmod: cannot operate on dangling symlink '/usr/local/bin/now' ``` Sample run: https://github.com/cilium/cilium/actions/runs/11343796440/job/31547213730?pr=35397 Signed-off-by: Tam Mach <tam.mach@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit e08929b ] The jq flag 'argfile' has been removed. The solution is to use slurpfile instead. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 2c40eb1 ] As multiple services can share the same VIP (e.g. using lbipam.cilium.io/sharing-key), the service reconciliation logic needs to be adapted to not withdraw a route to VIP that is still in use by some other service. To address that, this change introduces resource reference counting by reconciling service advertisements. This fix is specific to BGPv1 service reconciliation only. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit b3a3108 ] Updates the BGPv1 advertisement tests to test a case where multiple services share the same LoadBalancer VIP. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and looks good for my commit.
c3a2c49
to
5bab655
Compare
/test-backport-1.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nonblocking: if you happen to update commits for whatever reason, now my commit points to incorrect commit, while PR description points to correct one: 1918908
Oops, sorry. I updated it locally but forgot to force-push apparently. |
[ upstream commit d3dc7e8 ] [ backporter's note: added `any:` prefix as with other labels because commit 1918908 ("Improve identity-relevant-labels.rst page") which removed these prefixes across all docs wasn't backported to v1.16. ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied. Fixes: #31178 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
[ upstream commit f269eee ] It is useful to keep the image digests as long as possible, thus this commit removes the retention period of 10 days. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
5bab655
to
6be3749
Compare
/test-backport-1.16 |
any:
prefix as with other labels because commit 1918908 ("Improve identity-relevant-labels.rst page") which removed these prefixes across all docs wasn't backported tov1.16
.PRs skipped due to conflicts:
Once this PR is merged, a GitHub action will update the labels of these PRs: