pkg/ciliumidentity: Fix DeleteUsedCIDIsRecreated test #35466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @pippolo84 |
7877103 to
2a5a47d
Compare
dlapcevic
approved these changes
Oct 23, 2024
6e62e02 to
f97e41a
Compare
1149572 to
d2cac6d
Compare
Looks like `k8sClient.FakeClientset` is not properly synchronized and looks like is not properly propagating updating the store in a highly concurrent environment. Instead of relying on both .Events() and .List() moved to only .List() with Eventually() to nicely wait for the re-generation. The if statement could be replaced with a for-loop to break when encountering the identity not found, performed multiple stresstest runs and seems to behave similar. Keeping the test without the for-loop to speed up the testing. Signed-off-by: Ovidiu Tirla <otirla@google.com>
The initial sync is not required as the events are processed using the watcher .Events(). Signed-off-by: Ovidiu Tirla <otirla@google.com>
d2cac6d to
595aeaf
Compare
|
rebased on main |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
TestDeleteUsedCIDIsRecreatedby re-working the fakeclientset. Encountered synchronization issues on the client so moved to only check the .List() instead of both. Removed the initial sync and ordered the initial event processing.Fixes: #35135