Ariane: skip E2E tests when changing unit tests only #35334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blamed commits added the CODEOWNERS and USERS.md files to the paths-ignore-regex, to skip full CI for PRs touching only them (or any other ignored path). However, the current regex has a trailing / at the end, hence never matching single files. Let's rework the regex into two different groups, one for directory paths and another for single files. Fixes: df7a76e ("ci: Skip full CI for USERS.md file") Fixes: 12d6712 ("ariane: don't run full CI on CODEOWNERS change") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Skip running the full E2E tests when touching unit test files only, such as when fixing flakes. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
gandro
reviewed
Oct 10, 2024
I would say it doesn't hurt, although it is probably more unlikely to have PRs not touching code files as well on stable branches. That said, previous PRs modifying this config don't appear to have been backported, hence it would need to be a manual backport to essentially re-sync the configs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit messages for additional details.