Skip to content

[v1.16] gh: e2e-upgrade: restart LRP backend pod after upgrade #35329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented Oct 10, 2024

The lrp-backend pods are created on v1.15 without setting the netns cookie on the endpoint. So when the local-redirect-policy test runs later on v1.16 which relies on the netns cookie it fails.

This PR restarts the LRP backend pod to set the netns cookie after upgrading to v1.16.

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Oct 10, 2024
@ysksuzuki ysksuzuki changed the title gh: e2e-upgrade: restart LRP backend pod after upgrade [v1.16] gh: e2e-upgrade: restart LRP backend pod after upgrade Oct 10, 2024
@ysksuzuki
Copy link
Member Author

/test-backport-1.16

@ysksuzuki ysksuzuki added release-note/ci This PR makes changes to the CI. area/lrp Impacts Local Redirect Policy. labels Oct 10, 2024
The lrp-backend pods are created on v1.15 without setting the netns
cookie on the endpoint. So when the local-redirect-policy test runs
later on v1.16 which replies on the netns cookie it fails.

This commit restarts the LRP backend pod to set the netns cookie
after upgrading to v1.16.

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki ysksuzuki force-pushed the pr/ysksuzuki/restart-lrp-backend branch from 10419bd to c10d624 Compare October 10, 2024 07:17
@ysksuzuki
Copy link
Member Author

/test-backport-1.16

@ysksuzuki ysksuzuki marked this pull request as ready for review October 10, 2024 23:16
@ysksuzuki ysksuzuki requested review from a team as code owners October 10, 2024 23:16
@ysksuzuki ysksuzuki requested review from aanm and nebril October 10, 2024 23:16
@aanm aanm added this pull request to the merge queue Oct 11, 2024
Merged via the queue into v1.16 with commit ff759bc Oct 11, 2024
102 checks passed
@aanm aanm deleted the pr/ysksuzuki/restart-lrp-backend branch October 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lrp Impacts Local Redirect Policy. backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants