docker: Fix NOSTRIP option in cilium/Dockerfile #35326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR cilium#32660, the MODIFIERS build argument was added as a replacement for individual build arguments, one of which was NOSTRIP. There was an uncaught usage of NOSTRIP in cilium's Dockerfile, which has caused the NOSTRIP modifier to become a no-op. This commit fixes this usage, allowing for NOSTRIP to be used again. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
|
/test |
1 similar comment
|
/test |
borkmann
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
In PR #32660, the MODIFIERS build argument was added as a replacement for individual build arguments, one of which was NOSTRIP. There was an uncaught usage of NOSTRIP in cilium's Dockerfile, which has caused the NOSTRIP modifier to become a no-op. This commit fixes this usage, allowing for NOSTRIP to be used again.