-
Notifications
You must be signed in to change notification settings - Fork 3.4k
workflows: Extend IPsec tests to cover egress gateway #35323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04f03d1
to
b116ed2
Compare
aanm
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pchaigno shall we backport this PR?
aanm
requested changes
Oct 15, 2024
jschwinger233
approved these changes
Oct 15, 2024
952d970
to
2fd8fc5
Compare
nebril
approved these changes
Oct 17, 2024
72f88f9
to
bfa81a4
Compare
I don't think we can. IPsec+KPR is not supported in v1.15 so upgrade workflow would fail. |
1 task
julianwiedmann
added a commit
to julianwiedmann/cilium
that referenced
this pull request
Oct 28, 2024
Added by cilium#35323. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
Added by #35323. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Dec 4, 2024
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Dec 10, 2024
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Dec 13, 2024
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Dec 13, 2024
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Jan 7, 2025
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Jan 8, 2025
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
smagnani96
added a commit
that referenced
this pull request
Jan 10, 2025
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
rastislavs
pushed a commit
that referenced
this pull request
Jan 21, 2025
[ upstream commit a6ea748 ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com> Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
[ upstream commit a6ea748 ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com> Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
pushed a commit
that referenced
this pull request
Jan 22, 2025
[ upstream commit a6ea748 ] [ backporter's notes: manually resolved conflicts at multiple places caused by different surrounding context ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
rastislavs
pushed a commit
that referenced
this pull request
Jan 22, 2025
[ upstream commit a6ea748 ] [ backporter's notes: manually resolved conflicts at various places. There were no separate egress gateway testing steps present in this version of the workflow, but feature-status steps related to EGW were still present (probably were backported separately). ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
rastislavs
pushed a commit
that referenced
this pull request
Jan 22, 2025
[ upstream commit a6ea748 ] [ backporter's notes: manually resolved conflicts at various places. There were no separate egress gateway testing steps present in this version of the workflow, but feature-status steps related to EGW were still present (probably were backported separately). ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
christarazi
pushed a commit
that referenced
this pull request
Jan 22, 2025
[ upstream commit a6ea748 ] [ backporter's notes: manually resolved conflicts at various places. There were no separate egress gateway testing steps present in this version of the workflow, but feature-status steps related to EGW were still present (probably were backported separately). ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Jan 23, 2025
[ upstream commit a6ea748 ] [ backporter's notes: manually resolved conflicts at various places. There were no separate egress gateway testing steps present in this version of the workflow, but feature-status steps related to EGW were still present (probably were backported separately). ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
[ upstream commit a6ea748 ] [ backporter's notes: manually resolved conflicts at multiple places caused by different surrounding context ] In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in #35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
jongj
pushed a commit
to jongj/cilium
that referenced
this pull request
Feb 11, 2025
In the previous commit, we introduced to the bpftrace the capability to skip tracking traffic with destination address outside pod CIDRs. At this point, in conformance-ipsec-e2e tests we do not need to split tests anymore (egress-gateway vs all the others), previously modified in cilium#35323, "workflows/ipsec: Cover egress gateway", ea6bdac. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
feature/egress-gateway
Impacts the egress IP gateway feature.
feature/ipsec
Relates to Cilium's IPsec feature
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits are cleanup for the IPsec workflows. The third extends coverage to IPsec + KPR + egress gateway. The last one avoids the matrix deduplication and prettyfies the job display.