Skip to content

policy: Simplify L4PolicyMap Structure #35321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

policy: Simplify L4PolicyMap Structure #35321

merged 1 commit into from
Oct 10, 2024

Conversation

nathanjsweet
Copy link
Member

L4PolicyMap only needs an LPM structure for its
MatchLabels method. Similar to how MapState
separates the LPM index from the actual policy map
this commit does the same for L4PolicyMap. This
simplifies the logic of all the methods and reduces
the overhead of the ExactLookup method.

@nathanjsweet
policy: Simplify L4PolicyMap Structure
3feaa31 
L4PolicyMap only needs an LPM structure for its
`MatchLabels` method. Similar to how MapState
separates the LPM index from the actual policy map
this commit does the same for L4PolicyMap. This simplifies
the logic of all the methods and reduces the overhead of
the `ExactLookup` method.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet added the release-note/misc This PR makes changes that have no direct user impact. label Oct 9, 2024
@nathanjsweet nathanjsweet requested a review from a team as a code owner October 9, 2024 16:14
@nathanjsweet nathanjsweet requested a review from doniacld October 9, 2024 16:14
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label Oct 9, 2024
@nathanjsweet
Copy link
Member Author

/test

1 similar comment
@nathanjsweet
Copy link
Member Author

/test

doniacld
doniacld approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@doniacld doniacld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👏🏼

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 10, 2024
@aanm aanm added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 5d0e9d3 Oct 10, 2024
327 of 439 checks passed
@aanm aanm deleted the pr/nathanjsweet/simplify-policy-repository-datastructure branch October 10, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@doniacld doniacld doniacld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanjsweet @doniacld @aanm