container/set: fix bug in Set[T].Equal, increase test coverage
#35315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Set type is currently only used in pkg/policy. Make sure future changes don't have implications on the policy engine by assigning it to the corresponding team. Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
/test |
Currently, if the sets being compared contain more that a single element each, only the first element would be checked. Fix Set[T].Equal to consider all elements in both maps and also add an additional test cheing two maps of equal length with some different elements that would fail before this fix but pass afterwards. Fixes: 75181db ("containers: Add new set.Set type") Signed-off-by: Tobias Klauser <tobias@cilium.io>
Increase the test coverage of TestSet by: - Testing that calling Insert twice with the same value on a previously empty set will not change the Set (i.e. return false) on the second Insert call. - Adding test coverage for the previously uncovered RemoveSets method. - Adding test coverage for Members and MembersOfType on single entry Sets. Combined these changes increast test coverage from ~75% to ~87%. Signed-off-by: Tobias Klauser <tobias@cilium.io>
e1f8198 to
3561ca5
Compare
|
/test |
qmonnet
approved these changes
Oct 9, 2024
|
/ci-runtime Hit #34731 https://github.com/cilium/cilium/actions/runs/11255508705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in
Set[T].Equalintroduced in #34692. Also increase the test coverage to cover the single element case in all methods. Moreover, assignpkg/container/setto @cilium/sig-policy as this is the primary user of the package.See commits for details.