Skip to content

Fixed Cilium CLI fatal error: concurrent map read and map write #35311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fixed Cilium CLI fatal error: concurrent map read and map write #35311

merged 1 commit into from
Oct 11, 2024

Conversation

chaunceyjiang
Copy link
Member

Fixes #35222

Fixed Cilium CLI fatal error: concurrent map read and map write

@chaunceyjiang chaunceyjiang requested a review from a team as a code owner October 9, 2024 09:16
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 9, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Oct 9, 2024
@chaunceyjiang
Copy link
Member Author

/test

@michi-covalent michi-covalent added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Oct 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 11, 2024
@michi-covalent
Copy link
Contributor

@tommyp1ckles ping! 🏓

i asked @chaunceyjiang to add a bit more description in the commit message about how this fixes the issue 🚀🙏

@chaunceyjiang
Fixed Cilium CLI fatal error: concurrent map read and map write
3ded991 
Multiple goroutines accessing the same type registration in scheme.Scheme and performing type conversions can lead to concurrent read-write operations on the map.

Fixes cilium#35222

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@aanm
Copy link
Member

aanm commented Oct 11, 2024

/test

@aanm aanm enabled auto-merge October 11, 2024 13:28
@aanm aanm added this pull request to the merge queue Oct 11, 2024
Merged via the queue into cilium:main with commit cb31810 Oct 11, 2024
62 checks passed
@chaunceyjiang chaunceyjiang deleted the cilium_cli_panic branch October 12, 2024 01:54
@pchaigno
Copy link
Member

@chaunceyjiang We had to revert this pull request in #35391 as the end-to-end upgrade test was failing in several configurations (cf. https://github.com/cilium/cilium/actions/runs/11328217910).

@chaunceyjiang
Copy link
Member Author

as the end-to-end upgrade test was failing in several configurations (cf.

@pchaigno 🙀，let me take a look at this issue. The end-to-end upgrade test passed successfully when I merged this PR.

@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium CLI, connectivity tests: fatal error: concurrent map read and map write
4 participants
@chaunceyjiang @michi-covalent @aanm @pchaigno