Skip to content

docs: Trivial improvements to contributor guide #35307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

docs: Trivial improvements to contributor guide #35307

merged 1 commit into from
Oct 9, 2024

Conversation

pmatulis
Copy link
Contributor

@pmatulis pmatulis commented Oct 9, 2024

Hello 👋 . I'm new to Cilium and I was looking through the docs. To ensure a correct workflow with your project, I found a few trivial improvements to make.

Add some trivial improvements to the 'Clone and Provision Environment' section of the contributor guide.

@pmatulis
docs: Trivial improvements to contributor guide
44d1204 
Add some trivial improvements to the 'Clone and Provision Environment' section
of the contributor guide.

Signed-off-by: Peter Matulis <pmatulis@gmail.com>
@pmatulis pmatulis requested review from a team as code owners October 9, 2024 04:30
@pmatulis pmatulis requested a review from qmonnet October 9, 2024 04:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 9, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 9, 2024
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Oct 9, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 9, 2024
@qmonnet
Copy link
Member

qmonnet commented Oct 9, 2024

/test

qmonnet
qmonnet approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@qmonnet qmonnet enabled auto-merge October 9, 2024 09:11
@qmonnet qmonnet added this pull request to the merge queue Oct 9, 2024
Merged via the queue into cilium:main with commit 6f3aa77 Oct 9, 2024
66 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 9, 2024
@pmatulis pmatulis deleted the docs-trivial-fix branch October 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmatulis @qmonnet