Skip to content

helm: Fix configmap unmarshal error on egressGateway.maxPolicyEntries #35301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

helm: Fix configmap unmarshal error on egressGateway.maxPolicyEntries #35301

merged 1 commit into from
Oct 9, 2024

Conversation

hox
Copy link
Contributor

@hox hox commented Oct 8, 2024

Fixes an issue in the egressGateway.maxPolicyEntries section of the Cilium helm chart, when given a value it will give an error failing to unmarshal the numeric value set in the helm values as the ConfigMap can only hold strings.

Error given when attempting to set egressGateway.maxPolicyEntries=65536

ConfigMap in version "v1" cannot be handled as a ConfigMap: json: cannot unmarshal number into Go struct field ConfigMap.data of type string

This PR adds the missing | quote in the configmap template so it may properly pass the validation.

@hox
helm: fix configmap unmarshal error on egressGateway.maxPolicyEntries
c13bf80 
Signed-off-by: Elias Hernandez <elirayhernandez@gmail.com>
@hox hox requested review from a team as code owners October 8, 2024 17:00
@hox hox requested review from nathanjsweet and gandro October 8, 2024 17:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 8, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 8, 2024
@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 8, 2024
@joestringer joestringer added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch affects/v1.14 This issue affects v1.14 branch affects/v1.15 This issue affects v1.15 branch and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Oct 8, 2024
joestringer
joestringer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joestringer
Copy link
Member

/test

@joestringer joestringer enabled auto-merge October 8, 2024 18:50
@julianwiedmann julianwiedmann added the feature/egress-gateway Impacts the egress IP gateway feature. label Oct 9, 2024
gandro
gandro approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joestringer joestringer added this pull request to the merge queue Oct 9, 2024
@gandro gandro removed the request for review from nathanjsweet October 9, 2024 08:22
Merged via the queue into cilium:main with commit 9a45d31 Oct 9, 2024
73 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 9, 2024
@giorio94 giorio94 mentioned this pull request Oct 9, 2024
Merged
5 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 9, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Oct 16, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
affects/v1.14 This issue affects v1.14 branch affects/v1.15 This issue affects v1.15 branch backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/egress-gateway Impacts the egress IP gateway feature. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hox @joestringer @gandro @julianwiedmann @giorio94