Skip to content

.github/conformance-ginkgo: replace deprecated jq flag #35399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

.github/conformance-ginkgo: replace deprecated jq flag #35399

merged 1 commit into from
Oct 15, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Oct 15, 2024

The jq flag 'argfile' has been removed. The solution is to use slurpfile instead.

@aanm aanm requested a review from sayboras October 15, 2024 10:34
@aanm aanm requested review from a team as code owners October 15, 2024 10:34
@aanm aanm requested a review from brlbil October 15, 2024 10:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@aanm
Copy link
Member Author

aanm commented Oct 15, 2024

/test

@aanm aanm added needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Oct 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 15, 2024
sayboras
sayboras approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@aanm aanm enabled auto-merge October 15, 2024 10:34
@aanm
.github/conformance-ginkgo: replace deprecated jq flag
c9c8747 
The jq flag 'argfile' has been removed. The solution is
to use slurpfile instead.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/replace-deprecated-jq-flag branch from e09e5f3 to c9c8747 Compare October 15, 2024 10:42
@aanm
Copy link
Member Author

aanm commented Oct 15, 2024

/ci-ginkgo

@aanm
Copy link
Member Author

aanm commented Oct 15, 2024

/test

@aanm aanm added this pull request to the merge queue Oct 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 15, 2024
Merged via the queue into main with commit e08929b Oct 15, 2024
118 of 122 checks passed
@aanm aanm deleted the pr/replace-deprecated-jq-flag branch October 15, 2024 11:16
@tklauser tklauser mentioned this pull request Oct 22, 2024
Merged
10 tasks
@tklauser tklauser added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Oct 22, 2024
@tklauser tklauser mentioned this pull request Oct 22, 2024
Merged
4 tasks
@tklauser tklauser added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Oct 22, 2024
@tklauser tklauser mentioned this pull request Oct 22, 2024
Merged
5 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Oct 22, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Oct 22, 2024
This was referenced Nov 13, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aanm @brlbil @sayboras @tklauser