logging: consistent error attribute when emitted through logr #35397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacce32 to
729e52e
Compare
|
/test |
mhofstetter
reviewed
Oct 15, 2024
Slightly generalize the log attributes mangling logic in preparation for the subsequent extension, changing the function names to be agnostic of the specific operations and making one rely on the other, to ensure consistency and reduce code duplication. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Extend the log attributes mangling logic to ensure consistency in the attribute key used to identify an error. Indeed, the logr.Error method takes an error as first parameter, and the slog adapter converts it into an attribute identified as `err`. Let's replace that into `error` to ensure consistency with all the other occurrences. Related: d91e387 ("cec: Switch to slog for CEC") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
729e52e to
4125b1c
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the log attributes mangling logic to ensure consistency in the attribute key used to identify an error. Indeed, the
logr.Errormethod takes an error as first parameter, and the slog adapter converts it into an attribute identified aserr. Let's replace that intoerrorto ensure consistency with all the other occurrences.