Skip to content

Conversation

chaunceyjiang
Copy link
Member

Multiple goroutines accessing the same type registration in scheme.Scheme and performing type conversions can lead to concurrent read-write operations on the map.

Scheme only needs to be registered once, not multiple times, so it can be registered during initialization.

Fixes #35222

Fixed Cilium CLI fatal error: concurrent map read and map write

@chaunceyjiang chaunceyjiang requested a review from a team as a code owner October 15, 2024 09:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 15, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Oct 15, 2024
Multiple goroutines accessing the same type registration in scheme.Scheme and performing type conversions can lead to concurrent read-write operations on the map.

Scheme only needs to be registered once, not multiple times, so it can be registered during initialization.

Fixes cilium#35222

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Member Author

/test

Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chaunceyjiang!

@chaunceyjiang
Copy link
Member Author

/ci-e2e-upgrade

@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Oct 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 15, 2024
@squeed squeed added this pull request to the merge queue Oct 15, 2024
Merged via the queue into cilium:main with commit 19075e4 Oct 15, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium CLI, connectivity tests: fatal error: concurrent map read and map write
4 participants