Skip to content

Conversation

yushoyamaguchi
Copy link
Member

Use error definition of github.com/cilium/ebpf, in which the bpf map errors are defined.

This commit is refactoring of 31652ab and 88ebd10 .

@yushoyamaguchi yushoyamaguchi requested review from a team as code owners October 14, 2024 06:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 14, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. labels Oct 14, 2024
@yushoyamaguchi
Copy link
Member Author

yushoyamaguchi commented Oct 16, 2024

@christarazi
Thank you for reviewing.
Could you give some release-note-label?

cc @tommyp1ckles

@christarazi christarazi added the release-note/misc This PR makes changes that have no direct user impact. label Oct 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 16, 2024
@yushoyamaguchi
Copy link
Member Author

@tommyp1ckles

I'm sorry for repeating mentioning.
Could you review and allow to execute further test?

@aanm aanm enabled auto-merge October 21, 2024 10:04
@aanm
Copy link
Member

aanm commented Oct 21, 2024

/test

@julianwiedmann julianwiedmann added the area/multicast Impacts the Multicast feature. label Oct 21, 2024
Use error definition of github.com/cilium/ebpf, in which the bpf map errors are defined.

Signed-off-by: Yusho Yamaguchi <yusho.yamaguchi@sony.com>
@aanm aanm force-pushed the cli/mcast_err_msg branch from b1ec7f5 to ac134b0 Compare October 21, 2024 15:30
@aanm
Copy link
Member

aanm commented Oct 21, 2024

/test

@aanm aanm added this pull request to the merge queue Oct 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 22, 2024
Merged via the queue into cilium:main with commit 1037713 Oct 22, 2024
62 checks passed
@yushoyamaguchi yushoyamaguchi deleted the cli/mcast_err_msg branch April 29, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multicast Impacts the Multicast feature. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants