Skip to content

CI: Add merge and upload composite action #35355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

CI: Add merge and upload composite action #35355

merged 1 commit into from
Oct 16, 2024

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Oct 11, 2024 •
edited
Loading

This PR extracts merge-upload job steps to a composite action to avoid repetition, and make changes easier.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 11, 2024
@brlbil brlbil changed the title Pr/brlbil/merge reusable workflow CI: Add merge and upload composite action Oct 11, 2024
@brlbil
Copy link
Contributor Author

brlbil commented Oct 11, 2024

/ci-runtime

@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 81ef860 to cdff8f8 Compare October 11, 2024 10:15
@brlbil brlbil added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/azure Impacts Azure based IPAM. release-note/ci This PR makes changes to the CI. and removed area/azure Impacts Azure based IPAM. labels Oct 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 11, 2024
@brlbil
Copy link
Contributor Author

brlbil commented Oct 11, 2024

/ci-runtime

@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from cdff8f8 to 64467f5 Compare October 14, 2024 10:22
@maintainer-s-little-helper
Copy link

Commit 64467f5 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 14, 2024
@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 64467f5 to b27e22a Compare October 14, 2024 11:54
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 14, 2024
@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch 2 times, most recently from 8b80785 to 6378f16 Compare October 15, 2024 12:12
@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-clustermesh

@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 6378f16 to 57ee1b8 Compare October 15, 2024 14:20
@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-clustermesh

@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-runtime

@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 57ee1b8 to 2a2eb8e Compare October 15, 2024 15:24
@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-runtime

@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-clustermesh

@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 2a2eb8e to bb826e0 Compare October 15, 2024 18:38
@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-runtime

@brlbil
Copy link
Contributor Author

brlbil commented Oct 15, 2024

/ci-clustermesh

@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch 2 times, most recently from a6a8ad7 to 72623b6 Compare October 16, 2024 07:39
@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 72623b6 to 9ee33d1 Compare October 16, 2024 08:33
@brlbil
Copy link
Contributor Author

brlbil commented Oct 16, 2024

/ci-runtime

@brlbil
Copy link
Contributor Author

brlbil commented Oct 16, 2024

/ci-clustermesh

@brlbil
CI: create merge and upload composite action
97be80c 
This commit extracts merge-upload job steps to a composite action
to avoid repetition, make changes easier

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/merge-reusable-workflow branch from 9ee33d1 to 97be80c Compare October 16, 2024 11:41
@brlbil
Copy link
Contributor Author

brlbil commented Oct 16, 2024

/ci-gke

@brlbil
Copy link
Contributor Author

brlbil commented Oct 16, 2024

/ci-aks

@brlbil
Copy link
Contributor Author

brlbil commented Oct 16, 2024

/test

@brlbil brlbil added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. labels Oct 16, 2024
@brlbil brlbil marked this pull request as ready for review October 16, 2024 16:13
@brlbil brlbil requested review from a team as code owners October 16, 2024 16:13
@brlbil brlbil requested review from pchaigno and giorio94 October 16, 2024 16:13
@pchaigno pchaigno added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 98ada1a Oct 16, 2024
280 checks passed
@pchaigno pchaigno deleted the pr/brlbil/merge-reusable-workflow branch October 16, 2024 17:16
@joestringer joestringer added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. backport/1.16 This PR represents a backport for Cilium 1.16.x of a PR that was merged to main. labels Aug 12, 2025
@joestringer joestringer mentioned this pull request Aug 12, 2025
Merged
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@giorio94 giorio94 Awaiting requested review from giorio94 giorio94 is a code owner automatically assigned from cilium/sig-clustermesh

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brlbil @pchaigno @joestringer