adjust encryption bit while tracing outgoing wireguard-encrypted packets #35354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8488357 to
467b26b
Compare
|
/test |
467b26b to
606136b
Compare
606136b to
906365a
Compare
|
/test |
906365a to
4722e91
Compare
4722e91 to
3fd8fdd
Compare
|
/test |
This commit adjusts the tracing reason on the egress path when WireGuard is active. In cilium#35183 we erroneously potentially override the trace reason with Wireguard and HostFirewall enabled: while the latter could modify the trace structure after a successful ct lookup, the WireGuard code would simply ignore that value with either just TRACE_REASON_ENCRYPTED or TRACE_REASON_UNKNOWN. With this commit, the WireGuard path set at most just the TRACE_REASON_ENCRYPTED bit only after checking that the packet is WireGuard-encrypted, preserving the previous tracing reason. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
3fd8fdd to
d0c3307
Compare
As discussed offline, I just dropped the respective commits and left only the first fix. |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we just set the tracing encryption bit rather than overwriting trace reasons, causing potential loss of information. Offending commit hash 8a67387, PR #35183.
NOTE: backport shouldn't be needed since the offending commit made it to pre-release only https://github.com/cilium/cilium/releases/tag/v1.17.0-pre.2.