image: Use cilium-builder instead of golang as operator builder image #35351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
This commit changes the builder image for cilium-operator to be the cilium-builder image, rather than the golang image. This change will allow for arm64 builds of the cilium-operator to be built with CGO enabled due to the cilium-builder image containing multi-platform C compilers. This build configuration is a stepping stone for other build-time features, such as CGO binaries with race detection enabled. Fixes: 35324 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
43a55c0 to
bbc62c2
Compare
|
/test |
borkmann
approved these changes
Oct 22, 2024
6 tasks
learnitall
added a commit
to learnitall/cilium
that referenced
this pull request
Nov 1, 2024
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See cilium#35351 and cilium#35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
This was referenced Nov 13, 2024
learnitall
added a commit
to learnitall/cilium
that referenced
this pull request
Nov 20, 2024
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See cilium#35351 and cilium#35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
added a commit
to learnitall/cilium
that referenced
this pull request
Nov 20, 2024
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See cilium#35351 and cilium#35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
added a commit
to learnitall/cilium
that referenced
this pull request
Nov 22, 2024
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See cilium#35351 and cilium#35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
added a commit
to learnitall/cilium
that referenced
this pull request
Dec 2, 2024
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See cilium#35351 and cilium#35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See #35351 and #35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
jschwinger233
pushed a commit
that referenced
this pull request
Dec 3, 2024
[ upstream commit f0d3f93 ] The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See #35351 and #35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: gray <greyschwinger@gmail.com>
jschwinger233
pushed a commit
that referenced
this pull request
Dec 3, 2024
[ upstream commit f0d3f93 ] The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See #35351 and #35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: gray <greyschwinger@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
[ upstream commit f0d3f93 ] The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See #35351 and #35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: gray <greyschwinger@gmail.com>
joestringer
pushed a commit
that referenced
this pull request
Dec 3, 2024
[ upstream commit f0d3f93 ] The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See #35351 and #35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com> Signed-off-by: gray <greyschwinger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the builder image for cilium-operator to be the cilium-builder image, rather than the golang image. This change will allow for arm64 builds of the cilium-operator to be built with CGO enabled due to the cilium-builder image containing multi-platform C compilers. This build configuration is a stepping stone for other build-time features, such as CGO binaries with race detection enabled.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #35324