Skip to content

ipsec: Refactor IPSecDir #35346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2024
Merged

ipsec: Refactor IPSecDir #35346

merged 2 commits into from
Oct 22, 2024

Conversation

pchaigno
Copy link
Member

See commits. No functional changes.

@pchaigno pchaigno added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. feature/ipsec Relates to Cilium's IPsec feature labels Oct 10, 2024
@pchaigno pchaigno mentioned this pull request Oct 10, 2024
Merged
@pchaigno pchaigno marked this pull request as ready for review October 10, 2024 18:22
@pchaigno pchaigno requested a review from a team as a code owner October 10, 2024 18:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 11, 2024
@aanm aanm added this pull request to the merge queue Oct 11, 2024
@pchaigno pchaigno removed this pull request from the merge queue due to a manual request Oct 11, 2024
@pchaigno pchaigno added dont-merge/blocked Another PR must be merged before this one. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Oct 11, 2024
@pchaigno
Copy link
Member Author

Waiting for @ldelossa to merge his PR first as it conflicts with this one and is more painful to rebase.

@pchaigno pchaigno removed the dont-merge/blocked Another PR must be merged before this one. label Oct 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 21, 2024
@pchaigno pchaigno force-pushed the remove-IPSecDirOutNode branch 2 times, most recently from 0b8e017 to 2019985 Compare October 21, 2024 10:54
@pchaigno pchaigno enabled auto-merge October 21, 2024 10:54
ldelossa
ldelossa reviewed Oct 21, 2024
View reviewed changes
@pchaigno
ipsec: Remove unused IPSecDirOutNode constant
9fb8f4c 
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the remove-IPSecDirOutNode branch from 2019985 to 8d1e642 Compare October 21, 2024 16:55
@pchaigno
ipsec: Define IPSecDir as flags instead of strings
148d2cb 
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the remove-IPSecDirOutNode branch from 8d1e642 to 148d2cb Compare October 21, 2024 16:56
@pchaigno
Copy link
Member Author

/test

@pchaigno pchaigno added this pull request to the merge queue Oct 22, 2024
Merged via the queue into cilium:main with commit a8bde25 Oct 22, 2024
63 checks passed
@pchaigno pchaigno deleted the remove-IPSecDirOutNode branch October 22, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees
No one assigned
Labels
feature/ipsec Relates to Cilium's IPsec feature kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchaigno @ldelossa @jschwinger233