Skip to content

Conversation

julianwiedmann
Copy link
Member

The policy enforcement bullet in the referenced issue (#5719) is completed. Looks like the network policy support was added with #20033.

The `policy enforcement` bullet in the referenced issue
(cilium#5719) is completed. Looks like
the network policy support was added with
cilium#20033.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. labels Oct 4, 2024
@julianwiedmann julianwiedmann requested a review from a team October 4, 2024 15:33
@julianwiedmann julianwiedmann requested a review from a team as a code owner October 4, 2024 15:33
@julianwiedmann julianwiedmann removed the request for review from a team October 4, 2024 15:33
@julianwiedmann julianwiedmann requested a review from a team as a code owner October 4, 2024 15:33
@julianwiedmann
Copy link
Member Author

/test

@nathanjsweet nathanjsweet added this pull request to the merge queue Oct 4, 2024
Merged via the queue into cilium:main with commit 475310f Oct 4, 2024
72 checks passed
@julianwiedmann julianwiedmann deleted the 1.17-sctp-docs branch October 4, 2024 16:31
@joestringer
Copy link
Member

The referenced issue isn't completed, and SCTP support is broken if there's a k8s service in front (since we can't generate SCTP hashes => can't rewrite addresses / perform NAT). Should we revert this change?

@julianwiedmann
Copy link
Member Author

The referenced issue isn't completed, and SCTP support is broken if there's a k8s service in front (since we can't generate SCTP hashes => can't rewrite addresses / perform NAT). Should we revert this change?

What's missing for Kubernetes Network Policy with SCTP?

@joestringer
Copy link
Member

I see what you're saying. SCTP can be not fully implemented but as long as the policy primitive is supported then this note should not exist in the docs under network policy.

I was thinking from an end-to-end perspective that if someone connects to a Kubernetes service over SCTP, then network policy will not allow the traffic. The underlying cause is not the policy engine but it's because we don't support services with SCTP. The end result is that SCTP may not fully work. But perhaps if that's the nuance we're going for, it should be mentioned as a limitation somewhere else in the docs rather than in the network policy section.

👍 makes sense to me. No need to take action on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants