.github/build-images-base: checkout base branch to get scripts #35236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to checkout the base branch, instead of the default branch, to checkout the right scripts to generate the source code respectively of the stable branch the GH workflow is running from otherwise we will always run the scripts from the main branch from stable branches. Fixes: ada2560 (".github: run scripts from trusted source code") Signed-off-by: André Martins <andre@cilium.io>
|
/test |
joestringer
reviewed
Oct 4, 2024
joestringer
approved these changes
Oct 7, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to checkout the base branch, instead of the default branch, to checkout the right scripts to generate the source code respectively of the stable branch the GH workflow is running from otherwise we will always run the scripts from the main branch from stable branches.
Fixes: ada2560 (".github: run scripts from trusted source code")