Skip to content

ci: run privileged tests in parallel except for IPSec #35232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2024
Merged

ci: run privileged tests in parallel except for IPSec #35232

merged 2 commits into from
Oct 21, 2024

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Oct 4, 2024 •
edited
Loading

Small drawbacks of this approach:

  • if one of the tests fails, it won't run IPSec tests
  • we don't generate coverage report for IPSec tests

Additionally, switch from junit to tparse.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2024
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2024

/ci-runtime

@marseel marseel force-pushed the pr/marseel/fix_runtime_privileged branch from 2b1c302 to a4c3f76 Compare October 4, 2024 13:23
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2024

/ci-runtime

@marseel marseel added the release-note/ci This PR makes changes to the CI. label Oct 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2024
@marseel marseel force-pushed the pr/marseel/fix_runtime_privileged branch from a4c3f76 to d50c441 Compare October 4, 2024 14:13
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2024

/ci-runtime

1 similar comment
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2024

/ci-runtime

@marseel marseel force-pushed the pr/marseel/fix_runtime_privileged branch from 2bfc7a1 to 8fb3fec Compare October 4, 2024 15:59
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2024

/ci-runtime

@marseel marseel force-pushed the pr/marseel/fix_runtime_privileged branch from 8fb3fec to 1b46e7d Compare October 7, 2024 09:53
@marseel
Copy link
Contributor Author

marseel commented Oct 7, 2024

/ci-runtime

@marseel
Copy link
Contributor Author

marseel commented Oct 7, 2024

/test

@marseel marseel requested a review from aanm October 7, 2024 12:17
@marseel marseel marked this pull request as ready for review October 7, 2024 12:17
@marseel marseel requested review from a team as code owners October 7, 2024 12:17
@marseel marseel requested a review from pchaigno October 7, 2024 12:17
@pchaigno pchaigno requested a review from smagnani96 October 7, 2024 12:26
@aanm aanm enabled auto-merge October 7, 2024 14:34
smagnani96
smagnani96 reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@smagnani96 smagnani96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left a couple of comments.
Overall the change looks good, but maybe we could still provide coverage for IPSec tests despite being executed separately. Let me know your opinion 😃

@marseel marseel force-pushed the pr/marseel/fix_runtime_privileged branch from 1b46e7d to dfb6ffd Compare October 8, 2024 11:08
@marseel
Copy link
Contributor Author

marseel commented Oct 8, 2024

/ci-runtime

@marseel
Copy link
Contributor Author

marseel commented Oct 21, 2024

/test

marseel and others added 2 commits October 21, 2024 11:32
@marseel
ci: run privileged tests in parallel except for IPSec
8d60ac9 
One small drawback of this is that if first tests fail,
second part of tests is not run.

Additionally switch from junit to tparse.
Previously junit didn't work, but also didn't provide much value as we
also run regular unit tests.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@aanm @marseel
tests: skip test coverage report if SKIP_COVERAGE is set
85f46b5 
When running runtime tests on GH workflows we don't use the generated
coverage report. Thus, we can skip it entirely.

Signed-off-by: André Martins <andre@cilium.io>
@marseel marseel force-pushed the pr/marseel/fix_runtime_privileged branch from dfb6ffd to 85f46b5 Compare October 21, 2024 09:32
@marseel
Copy link
Contributor Author

marseel commented Oct 21, 2024

/test

@marseel
Copy link
Contributor Author

marseel commented Oct 21, 2024

/ci-ipsec-upgrade

@aanm aanm added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit a487ef0 Oct 21, 2024
283 of 284 checks passed
@aanm aanm deleted the pr/marseel/fix_runtime_privileged branch October 21, 2024 13:23
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

@smagnani96 smagnani96 smagnani96 approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marseel @pchaigno @aanm @smagnani96